Closed Bug 1699188 Opened 3 years ago Closed 3 years ago

Pre-commit linting hook ModuleNotFoundError: No module named 'jsmin'

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Probably similar to bug 1623741 likely regressed by bug 1636797 which added from mozpack.files import FileListFinder.

Traceback (most recent call last):
  File ".git/hooks/pre-commit", line 21, in <module>
    from mozversioncontrol import get_repository_object, InvalidRepoPath
  File "mozilla-central/tools/lint/../../python/mozversioncontrol/mozversioncontrol/__init__.py", line 17, in <module>
    from mozpack.files import FileListFinder
  File "mozilla-central/tools/lint/../../python/mozbuild/mozpack/files.py", line 42, in <module>
    from jsmin import JavascriptMinify
ModuleNotFoundError: No module named 'jsmin'
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d4bc56f77a1
[mozlint] Include jsmin now that mozversioncontrol uses it r=ahal
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Has Regression Range: --- → yes
Keywords: regression
See Also: → 1753739
Type: task → defect
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: