1699237 - Show Pin instead of Default screen for Windows

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

Using bug 1694257, we can show different defaults with various conditions. We'll want to show the pin & default screen using the strings from bug 1698962.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1699237 - Show Pin instead of Default screen for Windows. r?pdahiya,andreio

Depends on D108835

Comment 2

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We have received initial 87 experiment data showing onboarding with 1-click-pin improves days of use https://experimenter.services.mozilla.com/nimbus/1-click-pin-during-onboarding/results so we want to turn this on as soon as possible with a JSON change.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

We're building the 88.0 RC tomorrow (Monday). I'll take it as a ride-along if it's ready by then, but it's not going to block the build.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a27d6b2eb4ea
Show Pin instead of Default screen for Windows. r=andreio

Comment 5

[Ed Lee :Mardak]

Comment on attachment 9209835 [details]
Bug 1699237 - Show Pin instead of Default screen for Windows. r?pdahiya,andreio

Beta/Release Uplift Approval Request

• User impact if declined: New windows users get the "default browser" welcome experience that does not include "pin" functionality that has shown to significantly help users get back to Firefox for more days of use.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Start a new profile on windows to see about:welcome with "Primary Browser" main button
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Already tested behaviors in 87 release experiment
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9209835 [details]
Bug 1699237 - Show Pin instead of Default screen for Windows. r?pdahiya,andreio

Approved for 88.0rc1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8090a3a2b587

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a27d6b2eb4ea

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

This enhancement was part of the work done on PI-990 which was signed off as GREEN. Considering this, I am changing the status to VERIFIED.