Closed Bug 1699266 Opened 2 years ago Closed 1 year ago

[meta] Remove internal uses of JSID_* APIs.

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: mgaudet, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: meta)

The JSID_* APIs like

Mostly are more obscure than the underlying JS::PropertyKey methods, and so for now we can remove internal uses of these APIs, and replace them with the appropriate JS::PropertyKey methods

Summary: [META] Remove internal uses of JSID_* APIs. → [meta] Remove internal uses of JSID_* APIs.
Depends on: 1699268
Keywords: meta
Whiteboard: meta
Severity: -- → N/A
Priority: -- → P3
Depends on: 1705195
Flags: needinfo?(post.kadirselcuk)
Flags: needinfo?(post.kadirselcuk) → needinfo?(sdetar)
Flags: needinfo?(mgaudet)
Flags: needinfo?(sdetar)
Flags: needinfo?(mgaudet)
Depends on: 1717279

After bug 1699268 and bug 1705195 land we still have JSID_IS_STRING/JSID_TO_STRING, JSID_IS_INT/JSID_TO_INT and JSID_IS_VOID.

We also have the related APIs like INT_TO_JSID, which is still missing a sensible replacement.

Depends on: 1754405

This is done now that bug 1754405 has landed.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.