1754405 - Remove remaining JSID_* APIs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

It's now pretty straight-forward to get rid of the remaining C-style APIs and clean up PropertyKey.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 1 - Remove JSID_IS_STRING/JSID_TO_STRING. r?evilpie!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 2 - Remove JSID_IS_INT/JSID_TO_INT. r?evilpie!

Depends on D138272

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 3 - Remove JSID_IS_VOID. r?evilpie!

Depends on D138273

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 4 - Remove JSID_TO_LINEAR_STRING. r?evilpie!

Depends on D138274

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 5 - Remove INT_FITS_IN_JSID/INT_TO_JSID. r?evilpie!

Depends on D138275

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 6 - Add JS::GetWellKnownSymbolKey. r?evilpie!

It's very common to call JS::GetWellKnownSymbol and then creating a PropertyKey.
We can make this a bit more ergonomic with this API.

Depends on D138276

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 7 - Remove SYMBOL_TO_JSID. r?evilpie!

Depends on D138277

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 8 - Rename JSID_VOID to PropertyKey::Void(). r?evilpie!

Depends on D138278

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 9 - Add PropertyKey::asRawBits. r?evilpie!

Depends on D138279

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 10 - Remove JSID_BITS. r?evilpie!

Depends on D138280

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 11 - Make PropertyKey bits field private. r?evilpie!

Also change from size_t to uintptr_t.

Depends on D138281

Comment 12

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 12 - Move type tag constants into PropertyKey. r?evilpie!

Depends on D138282

Comment 13

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 13 - Move min/max int constants into PropertyKey. r?evilpie!

Depends on D138283

Comment 14

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 15 - Fix gdb pretty printers. r?evilpie!

Depends on D138284

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6d164570075
part 1 - Remove JSID_IS_STRING/JSID_TO_STRING. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/6f6b6a6dd8f7
part 2 - Remove JSID_IS_INT/JSID_TO_INT. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/a593faefbad7
part 3 - Remove JSID_IS_VOID. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/e4f4811ae8ff
part 4 - Remove JSID_TO_LINEAR_STRING. r=evilpie

Comment 16

[Jan de Mooij [:jandem]]

Attachment: Bug 1754405 part 14 - Rename PropertyKey::fromNonIntAtom to PropertyKey::NonIntAtom. r?evilpie!

Depends on D138284

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f6d164570075
https://hg.mozilla.org/mozilla-central/rev/6f6b6a6dd8f7
https://hg.mozilla.org/mozilla-central/rev/a593faefbad7
https://hg.mozilla.org/mozilla-central/rev/e4f4811ae8ff

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04fd07f96d38
part 5 - Remove INT_FITS_IN_JSID/INT_TO_JSID. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/38128ccff550
part 6 - Add JS::GetWellKnownSymbolKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/75e45f7f6059
part 7 - Remove SYMBOL_TO_JSID. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/b74cec4cdb71
part 8 - Rename JSID_VOID to PropertyKey::Void(). r=evilpie
https://hg.mozilla.org/integration/autoland/rev/e9eb1c19565c
part 9 - Add PropertyKey::asRawBits. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/0fadeefca66a
part 10 - Remove JSID_BITS. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/0a7a67b4c67e
part 11 - Make PropertyKey bits field private. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/7b0041c599de
part 12 - Move type tag constants into PropertyKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/8ea332be8add
part 13 - Move min/max int constants into PropertyKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/60ad9ac4de32
part 14 - Rename PropertyKey::fromNonIntAtom to PropertyKey::NonIntAtom. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/b531d439f265
part 15 - Fix gdb pretty printers. r=evilpie

Comment 19

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/04fd07f96d38
https://hg.mozilla.org/mozilla-central/rev/38128ccff550
https://hg.mozilla.org/mozilla-central/rev/75e45f7f6059
https://hg.mozilla.org/mozilla-central/rev/b74cec4cdb71
https://hg.mozilla.org/mozilla-central/rev/e9eb1c19565c
https://hg.mozilla.org/mozilla-central/rev/0fadeefca66a
https://hg.mozilla.org/mozilla-central/rev/0a7a67b4c67e
https://hg.mozilla.org/mozilla-central/rev/7b0041c599de
https://hg.mozilla.org/mozilla-central/rev/8ea332be8add
https://hg.mozilla.org/mozilla-central/rev/60ad9ac4de32
https://hg.mozilla.org/mozilla-central/rev/b531d439f265