1699399 - Unreadable <select> fields (menulist / popups) when using the Proton dark theme

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Romain Testard [:RT]]

Attachment: white.gif

STR:
1 Set Proton dark theme and enable proton context menu
2 Go to https://signup.live.com/signup?lcid=1033&wa=wsignin1.0&rpsnv=13&ct=1616000757&rver=7.0.6737.0&wp=MBI_SSL&wreply=https%3a%2f%2foutlook.live.com%2fowa%2f%3fnlp%3d1%26signup%3d1%26RpsCsrfState%3dc236a12a-38e6-fa16-3d4a-a1bc412cce98&id=292841&CBCXT=out&lw=1&fl=dob%2cflname%2cwld&cobrandid=90015&lic=1&uaid=bfd87d46442d4e34a294d439cc0ebcc9
3 Open drop down and observe that drop down options are not visible

Comment 1

[:Gijs (he/him)]

Please set the whiteboard tag when you file bugs to ensure they show up in JIRA and our other tracking tools.

The root cause here is the same as bug 1692593.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1699399 - fix content select dropdown interaction with the Windows 10 proton context menu styling, r?mconley

This fix is in three parts:

• ensure SelectParent's concept of the 'UA style' of the dropdown matches with the dark theme.
  This ensures that we don't ignore black-text-on-white-bg page styles in dark mode because
  they match the default styles, and end up with unreadable text because only one of the
  foreground/background colours exactly matches the UA style. This isn't a complete fix for
  the problem of contrast in this menu, but that isn't really in-scope here...
• ensure the foreground colour that the win10 menu sets is on the menupopup, rather than the
  scrollbox. On the scrollbox it would cause the individual menuitems to inherit that, rather
  than the colour set by SelectParent on the menupopup.
• fix a broken variable reference for the foreground colour for hovered (_menuactive) items in
  menu.css, without which the foreground colour on the hover/active item was still wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31a4eb1729a6
fix content select dropdown interaction with the Windows 10 proton context menu styling, r=mconley

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/31a4eb1729a6

Comment 5

[Bogdan Maris, Desktop QA]

Reproduced the initial issue shown in comment 0 using an old Nightly from 2021-03-18, verified that using latest Nightly this is no longer an issue.