1699480 - GV Content Permissions overhaul part 2: add setPermission, update onContentPermissionRequest, and let Gecko persist permissions

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Dylan Roeh (:droeh) (he/him)]

Second major chunk of the permissions overhaul; adds manual permission setting, updates onContentPermissionRequest, and lets Gecko persist permissions.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi!,#geckoview-reviewers!

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Deprecate most existing TP exception API in GV and migrate it to new permissions API; also allow for importing/exporting ContentPermissions as JSONObjects. r=agi!,#geckoview-reviewers!

Depends on D112042

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Add tests for new GV permission functionality. r=#geckoview-reviewers!

Depends on D113134

Comment 4

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Update GV changelog for permissions API changes. r=#geckoview-reviewers!

Depends on D113421

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Add string-based setPermission with deprecation schedule so AC can import old permissions. r=agi!,#geckoview-reviewers!

Depends on D113422

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b85f1b5018
Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/29c805a86786
Deprecate most existing TP exception API in GV and migrate it to new permissions API; also allow for importing/exporting ContentPermissions as JSONObjects. r=agi,geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/0b19a5f1a3de
Add tests for new GV permission functionality. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/a21de0967cf5
Update GV changelog for permissions API changes. r=geckoview-reviewers,agi

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/25b85f1b5018
https://hg.mozilla.org/mozilla-central/rev/29c805a86786
https://hg.mozilla.org/mozilla-central/rev/0b19a5f1a3de
https://hg.mozilla.org/mozilla-central/rev/a21de0967cf5

Comment 8

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1699480 - Back out permissions changes at AC's request, r=#geckoview-reviewers!

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3d1a6b0bb9f9

Comment 10

[Dylan Roeh (:droeh) (he/him)]

Reopening; we'll try to land again in 91 when AC is ready.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3005001299c
Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/425aa354f1ca
Deprecate most existing TP exception API in GV and migrate it to new permissions API; also allow for importing/exporting ContentPermissions as JSONObjects. r=agi,geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/68b5f5c2f1e6
Add tests for new GV permission functionality. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/e4be23f4dbe9
Update GV changelog for permissions API changes. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/5ed626994de6
Add string-based setPermission with deprecation schedule so AC can import old permissions. r=agi,geckoview-reviewers

Comment 12

[Alexandru Michis [:malexandru]]

Backed out 5 changesets (bug 1699480) for causing lint failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/d3303869191ca5b5ebe70c73872e4b6b2d6b57b5
Push with failures, failure log.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c79393946cc
Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/d63350c507b2
Deprecate most existing TP exception API in GV and migrate it to new permissions API; also allow for importing/exporting ContentPermissions as JSONObjects. r=agi,geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/a0c165b57dd7
Add tests for new GV permission functionality. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/c0f151c2bb4e
Update GV changelog for permissions API changes. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/cd408af42e47
Add string-based setPermission with deprecation schedule so AC can import old permissions. r=agi,geckoview-reviewers

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9c79393946cc
https://hg.mozilla.org/mozilla-central/rev/d63350c507b2
https://hg.mozilla.org/mozilla-central/rev/a0c165b57dd7
https://hg.mozilla.org/mozilla-central/rev/c0f151c2bb4e
https://hg.mozilla.org/mozilla-central/rev/cd408af42e47