Closed Bug 1699593 Opened 2 years ago Closed 2 years ago

Remove default icon styles from info-pages.css .title class

Categories

(Toolkit :: Themes, task, P3)

Product:
Toolkit
Component:
Themes
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: ntim, Assigned: pestanoa)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file, 1 obsolete file)

Bug 1699593 - Removed default icon styles from .title class. r=mhowell,mtigley
48 bytes, text/x-phabricator-request
Details | Review

This only made sense with the original designs from 2014 in bug 1087618. Although nowadays most pages use illustrations and soon less/no icons/illustrations will be used (bug 1693815).

It's worth removing the default icon styles from .title, so not every page has to reset the background-image. See:

https://searchfox.org/mozilla-central/rev/200bfc652c5128011e7725fc7c201eb125d453e7/toolkit/themes/shared/in-content/info-pages.inc.css#40-55

and everywhere that does .title { background-image: none } can be cleaned up as well.

Depends on: 1693815
Priority: -- → P5
Priority: P5 → P3
Points: --- → 1
Assignee: nobody → pestanoa
Status: NEW → ASSIGNED
Attachment #9240820 - Attachment is obsolete: true
Attachment #9240738 - Attachment description: Bug 1699593 - Removed default icon stlyes from .title class. r=mhowell,mtigley → Bug 1699593 - Removed default icon styles from .title class. r=mhowell,mtigley
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0209cad9295
Removed default icon styles from .title class. r=mhowell,mtigley,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/b0209cad9295

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Regressions: 1731618
You need to log in before you can comment on or make changes to this bug.