1699631 - De-duplicate refresh icon SVGs

Status: VERIFIED FIXED

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

• toolkit/themes/shared/icons/icon-refresh.svg
  this one was taken from the fxr directory for the restart to update thing, it should have taken the reload.svg from browser instead
• browser/themes/shared/icons/menus/reload.svg
  this one was introduced along with the new Windows context menu style, and should be irrelevant with the new proton icon drop
• browser/themes/shared/icons/reload.svg

DevTools also have duplicate icons (but could be solved separately):

• devtools/client/debugger/images/reload.svg
• devtools/client/themes/images/reload.svg

Suggested plan:

• icon-refresh.svg moved back to browser/fxr/content/assets/
• reload.svg moved to toolkit/themes/shared/icons
• remove browser/themes/shared/icons/menus/reload.svg
• make everything except devtools & fxr use the toolkit icon

Comment 1

[Sam Foster [:sfoster] (he/him)]

(In reply to Tim Nguyen :ntim from comment #0)

Suggested plan:

• icon-refresh.svg moved back to browser/fxr/content/assets/
  This is being taken care of in bug 1704970

• reload.svg moved to toolkit/themes/shared/icons
• remove browser/themes/shared/icons/menus/reload.svg
  This was already done

• make everything except devtools & fxr use the toolkit icon

So this patch will really just be moving the reload.svg into toolkit. Which seems like the better place for it.

Comment 2

[Rares Doghi, Desktop QA]

Hi Molly, I noticed that there are 3 separate files named reload.svg and 2 of them are identical, one of them, the one from devtools I think, its a bit thicker, the one from the Storage tab. Is it normal to have 3 files with the same name but different images for them ?

Is the purpose of this issue to remove any extra icons with the same name ? Are these all the places where the reload icon is displayed ?

In the About Firefox modal after update is performed and the user has to restart.
In the Browser next to the URL bar.
In the Devtools - Storage tab.

Any other places where these icons might be used ?

Comment 3

[Molly Howell (she/her) (no longer active)]

It looks like the devtools ones are being handled separately, so don't worry about those for this bug.

browser/themes/shared/icons/reload.svg shows up all over the place; in addition to what you've listed, it's in the page context menu, on the MacBook touch bar, in the downloads panel (as a "retry" button when a download fails or is cancelled), in the tracking protection settings (when you change that setting, there's a prompt to reload all tabs), and somewhere in the dialog for pairing a new sync device.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1699631 - Move the reload icon into toolkit. r?harry!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47653711a25
Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers

Comment 6

[Marian-Vasile Laza]

Backed out changeset c47653711a25 (Bug 1699631) for causing node devtools failures.
Backout link
Push with failures
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e208957a93
Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers

Comment 8

[Sam Foster [:sfoster] (he/him)]

Thanks for the backout. I found the docs to update the devtool's snapshots that caused that test to fail - and have re-pushed.

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e3e208957a93

Comment 10

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 92.0a1 (2021-07-13) on Window, Mac and Ubuntu.