Closed Bug 1699631 Opened 9 months ago Closed 5 months ago

De-duplicate refresh icon SVGs

Categories

(Toolkit :: Themes, task, P3)

task
Points:
1

Tracking

()

VERIFIED FIXED
92 Branch
Tracking Status
firefox92 --- verified

People

(Reporter: ntim, Assigned: sfoster)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-cleanups][proton-icons])

Attachments

(1 file)

  • toolkit/themes/shared/icons/icon-refresh.svg
    this one was taken from the fxr directory for the restart to update thing, it should have taken the reload.svg from browser instead
  • browser/themes/shared/icons/menus/reload.svg
    this one was introduced along with the new Windows context menu style, and should be irrelevant with the new proton icon drop
  • browser/themes/shared/icons/reload.svg

DevTools also have duplicate icons (but could be solved separately):

  • devtools/client/debugger/images/reload.svg
  • devtools/client/themes/images/reload.svg

Suggested plan:

  • icon-refresh.svg moved back to browser/fxr/content/assets/
  • reload.svg moved to toolkit/themes/shared/icons
  • remove browser/themes/shared/icons/menus/reload.svg
  • make everything except devtools & fxr use the toolkit icon
Blocks: proton-icons
Whiteboard: [proton-cleanups] → [proton-cleanups][proton-icons]
Priority: -- → P5
Priority: P5 → P3
Points: --- → 1
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

(In reply to Tim Nguyen :ntim from comment #0)

Suggested plan:

  • icon-refresh.svg moved back to browser/fxr/content/assets/
    This is being taken care of in bug 1704970
  • reload.svg moved to toolkit/themes/shared/icons
  • remove browser/themes/shared/icons/menus/reload.svg
    This was already done
  • make everything except devtools & fxr use the toolkit icon

So this patch will really just be moving the reload.svg into toolkit. Which seems like the better place for it.

Hi Molly, I noticed that there are 3 separate files named reload.svg and 2 of them are identical, one of them, the one from devtools I think, its a bit thicker, the one from the Storage tab. Is it normal to have 3 files with the same name but different images for them ?

Is the purpose of this issue to remove any extra icons with the same name ? Are these all the places where the reload icon is displayed ?

In the About Firefox modal after update is performed and the user has to restart.
In the Browser next to the URL bar.
In the Devtools - Storage tab.

Any other places where these icons might be used ?

Flags: needinfo?(mhowell)

It looks like the devtools ones are being handled separately, so don't worry about those for this bug.

browser/themes/shared/icons/reload.svg shows up all over the place; in addition to what you've listed, it's in the page context menu, on the MacBook touch bar, in the downloads panel (as a "retry" button when a download fails or is cancelled), in the tracking protection settings (when you change that setting, there's a prompt to reload all tabs), and somewhere in the dialog for pairing a new sync device.

Flags: needinfo?(mhowell)
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c47653711a25
Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers

Backed out changeset c47653711a25 (Bug 1699631) for causing node devtools failures.
Backout link
Push with failures
Failure Log

Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3e208957a93
Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers

Thanks for the backout. I found the docs to update the devtool's snapshots that caused that test to fail - and have re-pushed.

Flags: needinfo?(sfoster)
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

This issue is verified as fixed in our latest Nightly build 92.0a1 (2021-07-13) on Window, Mac and Ubuntu.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.