1699853 - s/GetCrossDocParentFrame/GetCrossDocParentFrameInProcess/ in DOMIntersectionObserver.cpp "ComputeTheIntersection()"

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

Per bug 1698680, we're adding a new wrapper-API called GetCrossDocParentFrameInProcess(), and we're migrating existing GetCrossDocParentFrame() calls to use the new function, after checking that they're OK with the fact that it doesn't cross processes for cross-origin content.

I'm filing this bug to convert the two calls in DOMIntersectionObserver.cpp ComputeTheIntersection()

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1699853: Use "InProcess" version of GetCrossDocParentFrame() in DOMIntersectionObserver.cpp. r?hiro

This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)

We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.

These two callsites in DOMIntersectionObserver.cpp are part of an algorithm
that was already modernized to work with fission in bug 1599795. In a
fission-enabled scenario: when we end up with null containerFrame due to
hitting an oop-iframe boundary, we should end up handling things properly via
our subsequent application of the passed-in "aRemoteDocumentVisibleRect" arg.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cc914a73a3f
Use "InProcess" version of GetCrossDocParentFrame() in DOMIntersectionObserver.cpp. r=emilio

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9cc914a73a3f

Comment 4

[Chris Peterson [:cpeterson]]

Setting Fission Milestone to M7a (the current Beta milestone) because this bug is blocking meta bug 1599913 which is a blocker for Fission M7a.