Closed Bug 1699885 Opened 2 years ago Closed 2 years ago

Remove browser/themes/shared/customizableui/menu-arrow.svg in/after proton

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- verified

People

(Reporter: sfoster, Assigned: masterwayz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-icons] [proton-cleanups])

Attachments

(1 obsolete file)

Once proton is the default in m-c, browser/themes/shared/customizableui/menu-arrow.svg should be removed (used in non-proton code only).

Priority: -- → P2
Priority: P2 → P3
Attachment #9218483 - Attachment is obsolete: true

bug 1714462 will remove this because it removes the non-proton media queries and tests will complain about unreferenced icons like this. I'll leave this open so we don't miss it.

Points: --- → 1
Depends on: 1714462
Assignee: nobody → bigiri
Status: NEW → ASSIGNED
Assignee: bigiri → nobody
Status: ASSIGNED → NEW
Whiteboard: [proton-cleanups] → [proton-icons] [proton-cleanups]
Assignee: nobody → michelle
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Fixed by bug 1714462!

Hi Molly, can you please help us verify this issue ? I dont understant what has been removed since the menu-arrow.svg icon is still used in the Hamburger menu and other menus, How can we verify the fix here ?

Flags: needinfo?(mhowell)

Well, I don't think there's any menu-arrow.svg still there, it looks like we're using arrow-left and arrow-right now. This menu-arrow.svg was only used as the non-Proton submenu arrow.

Flags: needinfo?(mhowell)

Thanks for the help, I cant find the menu-arrow.svg file in our latest Nightly build. This issue is verified as fixed. I will mark it accordingly.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
You need to log in before you can comment on or make changes to this bug.