1714462 - Remove most CSS rules using `not (-moz-proton)`

Status: VERIFIED FIXED

(Firefox :: General, task)

Description

[:Gijs (he/him)]

List: https://searchfox.org/mozilla-central/search?q=not+%28-moz-proton%29&path=&case=false&regexp=false

bug 1711519 is already removing some of these, but the majority will need removing separately.

These should be straightforward to rip out - generally speaking, they should not require any kind of reconciliation / unification with anything else, as they are simply unused now, so they can just be removed.

However, there are a few catches:

• unused images / CSS variables. These may need more removal work. To find these, run the https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_all_files_referenced.js and https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_parsable_css.js tests against a packaged build (ie after rebuilding, run ./mach package and then run the test with ./mach mochitest --appname dist
• some of the rules in the toolkit code that apply to menulists (and therefore potentially menus?) and checkboxes on macOS may need to stay, or the reftests in bug 1703630 will fail. Or we would need to fix that bug first - but I don't really want to block removing the majority of these on those 3 macOS tests.
• it would be useful to split up the patch into 2-3 chunks so that the patch sizes are reasonable and to help with reviewing - probably easiest to do one patch for toolkit/themes, one for browser/themes/shared (which would be pretty sizeable, but I don't see how better to split that up) and one for everything else.

Comment 1

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714462 - Part 1: Remove CSS rules from toolkit/themes using "not (-moz-proton)" r=emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e10dca5c585a
Part 1: Remove CSS rules from toolkit/themes using "not (-moz-proton)" r=emalysz

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e10dca5c585a

Comment 4

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714462 - Part 2: Remove CSS rules using "not (-moz-proton)" in miscellaneous files r=emalysz

Comment 5

[Michelle Goossens [:masterwayz]]

The remaining files that will be in part 3 are blocked by Bug 1703630

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89ef9bf1aaae
Part 2: Remove CSS rules using "not (-moz-proton)" in miscellaneous files r=emalysz

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/89ef9bf1aaae

Comment 8

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714462 - Part 3: Remove CSS rules from browser/themes using "not (-proton)" r=Gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc75d71a0a3a
Part 3: Remove CSS rules from browser/themes using "not (-proton)" r=Gijs,preferences-reviewers

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bc75d71a0a3a

Comment 11

[Ivan Shapovalov]

What happened to the symbolic icon (browser/branding/$theme/content/identity-icons-brand.svg), is it going away?

Comment 12

[:Gijs (he/him)]

(In reply to Ivan Shapovalov from comment #11)

What happened to the symbolic icon (browser/branding/$theme/content/identity-icons-brand.svg), is it going away?

This file is no longer present in mozilla-central, so yes, it is going (has gone) away. Why? Is this a problem for some reason?

Comment 13

[Michelle Goossens [:masterwayz]]

(In reply to Ivan Shapovalov from comment #11)

What happened to the symbolic icon (browser/branding/$theme/content/identity-icons-brand.svg), is it going away?

Yes. It caused test failures as the icon is now no longer referenced anywhere, meaning that it's no longer used.

Comment 14

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714462 - Part 3b: Fix a CSS typo edit in panelmultiview r=Gijs

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/872932df3282
Part 3b: Fix a CSS typo edit in panelmultiview r=Gijs

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/872932df3282

Comment 17

[:Gijs (he/him)]

I think we should call this done. We can do the last few toolkit ones in bug 1703630.

Comment 18

[Rares Doghi, Desktop QA]

Hi Gijs, Are there any icons here we can test on the qa side ? or are there any specific sections affected by this issue ? How can we verify this fix ?

Comment 19

[:Gijs (he/him)]

(In reply to Rares Doghi from comment #18)

Hi Gijs, Are there any icons here we can test on the qa side ? or are there any specific sections affected by this issue ? How can we verify this fix ?

Please can you check

• that about pages that have the brand (Firefox/Nightly) icon shown in the identity block in the address bar still do so (note not all about pages got this icon before; shouldn't have changed.)
• items with subviews in the hamburger menu, overflow menu etc. still show arrows in LTR and RTL indicating they expand to the side
• send to device view in fxa toolbar menu hasn't changed icons compared with Firefox 90
• about:sessionrestore and "server not found" error pages haven't changed compared with Fx 90

Thanks!

Comment 20

[Rares Doghi, Desktop QA]

Thanks Gijs, I was able to verify all those pages including RTL builds like AR and I couldnt find any issues, the Icons from the about pages are the exact same ones from the Firefox 90. build, Also tested the Arrows from the Hamburger menu and submenus as well as Library menu and other Menus as well, Send to Device has the same icons as Nightly 90. in the FXA menu from the Toolbar and nothing changed for the About:sessionrestore or server not found error pages.

I can confirm this issue is Verified as Fixed in Nightly 92.0a1 (2021-07-13) and Nightly 91.0a1 (2021-07-12).