Closed
Bug 1699907
Opened 3 years ago
Closed 3 years ago
Fix octal warning in mailWindowOverlay.js
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey 2.87
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.8)
Attachments
(1 file)
|
1.38 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Bug 573392 introduced a line with \000 in and Bug 766577 missed this when fixing other octal warnings.
[Approval Request Comment]
Regression caused by (bug #): 573392
User impact if declined: warning message in console
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9210518 -
Flags: review?(frgrahl)
Attachment #9210518 -
Flags: approval-comm-release?
Attachment #9210518 -
Flags: approval-comm-esr60?
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9210518 [details] [diff] [review]
1699907-octal-mailwindowoverlay-2538.patch
LGTM
Attachment #9210518 -
Flags: review?(frgrahl)
Attachment #9210518 -
Flags: review+
Attachment #9210518 -
Flags: approval-comm-release?
Attachment #9210518 -
Flags: approval-comm-release+
Attachment #9210518 -
Flags: approval-comm-esr60?
Attachment #9210518 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5ee9734c7e2d
Fix octal warning in mailWindowOverlay.js. r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
|
||
Updated•3 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
Whiteboard: SM2.53.8
Target Milestone: --- → seamonkey 2.87
|
|
||
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d4db2f82dbaec06a1376bc3edbcf82fb698591f9
Fix octal warning in mailWindowOverlay.js. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•