The default bug view has changed. See this FAQ.

fix "octal literals and octal escape sequences are deprecated" in c-c

RESOLVED FIXED in Thunderbird 16.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Irving, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 16.0
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #572890 +++

Since bug 514559, octal literals and octal escape sequences are deprecated in strict mode, resulting in warnings when starting Thunderbird (and possibly SeaMonkey)

JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/mailWindowOverlay.js, line 1386: octal literals and octal escape sequences are deprecated

While my most recent test run didn't give me warnings for these files, there are also octal literals in /mail/components/search/SpotlightIntegration.js and /mail/components/search/content/searchCommon.js (see https://bugzilla.mozilla.org/show_bug.cgi?id=670566#c55)
(Assignee)

Comment 1

5 years ago
Can I take this?
Assignee: nobody → acelists
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 635452 [details] [diff] [review]
patch for TB

All occurences I could find with a grep regex (/addressbook/* is already handled in a separate bug).

Does Seamonkey also want a global patch for all files?
Attachment #635452 - Flags: review?(mconley)
Attachment #635452 - Flags: feedback?(iann_bugzilla)

Comment 3

5 years ago
> Does Seamonkey also want a global patch for all files?
But of course!!
(Assignee)

Comment 4

5 years ago
Created attachment 635832 [details] [diff] [review]
patch for Seamonkey

Untested...
Attachment #635832 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Attachment #635452 - Flags: feedback?(iann_bugzilla)

Comment 5

5 years ago
Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey

Not sure if this is the best way or not, Neil might though.
Attachment #635832 - Flags: review?(iann_bugzilla) → review?(neil)

Comment 6

5 years ago
Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey

>-      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
>+      foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
In theory we could use -1 here instead (it is special-cased as 0664 in this one function).
Attachment #635832 - Flags: review?(neil) → review+
Comment on attachment 635452 [details] [diff] [review]
patch for TB

Review of attachment 635452 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me too. Thanks for the cleanup, aceman!
Attachment #635452 - Flags: review?(mconley) → review+
(Assignee)

Comment 8

5 years ago
(In reply to neil@parkwaycc.co.uk from comment #6)
> Comment on attachment 635832 [details] [diff] [review]
> patch for Seamonkey
> 
> >-      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
> >+      foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
> In theory we could use -1 here instead (it is special-cased as 0664 in this
> one function).

But the original permissions were 0666, so I didn't want to change them (even though they are probably unwanted to be world writable). The respestive module owners should fix the logic (perms) in their own patches.
Keywords: checkin-needed
Whiteboard: [checkin both patches]
https://hg.mozilla.org/comm-central/rev/05b0aa51099a
https://hg.mozilla.org/comm-central/rev/a98a0a64fc02
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [checkin both patches]
Target Milestone: --- → Thunderbird 16.0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.