766577 - fix "octal literals and octal escape sequences are deprecated" in c-c

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:Irving Reid (No longer working on Firefox)]

+++ This bug was initially created as a clone of Bug #572890 +++

Since bug 514559, octal literals and octal escape sequences are deprecated in strict mode, resulting in warnings when starting Thunderbird (and possibly SeaMonkey)

JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/mailWindowOverlay.js, line 1386: octal literals and octal escape sequences are deprecated

While my most recent test run didn't give me warnings for these files, there are also octal literals in /mail/components/search/SpotlightIntegration.js and /mail/components/search/content/searchCommon.js (see https://bugzilla.mozilla.org/show_bug.cgi?id=670566#c55)

Comment 1

[:aceman]

Can I take this?

Comment 2

[:aceman]

Attachment: patch for TB

All occurences I could find with a grep regex (/addressbook/* is already handled in a separate bug).

Does Seamonkey also want a global patch for all files?

Comment 3

[Philip Chee]

> Does Seamonkey also want a global patch for all files?
But of course!!

Comment 4

[:aceman]

Attachment: patch for Seamonkey

Untested...

Comment 5

[Ian Neal]

Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey

Not sure if this is the best way or not, Neil might though.

Comment 6

[[e-mail]]

Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey

>-      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
>+      foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
In theory we could use -1 here instead (it is special-cased as 0664 in this one function).

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 635452 [details] [diff] [review]
patch for TB

Review of attachment 635452 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me too. Thanks for the cleanup, aceman!

Comment 8

[:aceman]

(In reply to [e-mail] from comment #6)
> Comment on attachment 635832 [details] [diff] [review]
> patch for Seamonkey
> 
> >-      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
> >+      foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
> In theory we could use -1 here instead (it is special-cased as 0664 in this
> one function).

But the original permissions were 0666, so I didn't want to change them (even though they are probably unwanted to be world writable). The respestive module owners should fix the logic (perms) in their own patches.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/05b0aa51099a
https://hg.mozilla.org/comm-central/rev/a98a0a64fc02