1699937 - Improve box-shadow rendering in the non-native theme.

Status: RESOLVED FIXED

(Core :: Web Painting, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699937 - Don't draw focus outlines for box-shadow in the non-native theme. r=mstange

This is a relatively easy way to improve the rendering with the
non-native theme while not regressing anything.

In the future, once non-native-theme is shipped and default everywhere,
I think we could provide something like:

bool nsITheme::GetShadowRect(nsIFrame*, StyleAppearance, LayoutDeviceRect&, RectCornerRadii&)

or such, where we can provide a precise rect + radii, and we would avoid
painting the shadow if the function returned false. That would allow us
to remove the native theme box shadow code path, and avoid WR fallback,
all at once.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e01e2b7b4a08
Don't draw focus outlines for box-shadow in the non-native theme. r=mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/303ea40a2e2f
Fix test annotation for test that's expected to fail now.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e01e2b7b4a08
https://hg.mozilla.org/mozilla-central/rev/303ea40a2e2f