Closed Bug 1699937 Opened 4 years ago Closed 4 years ago

Improve box-shadow rendering in the non-native theme.

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

This is a relatively easy way to improve the rendering with the
non-native theme while not regressing anything.

In the future, once non-native-theme is shipped and default everywhere,
I think we could provide something like:

bool nsITheme::GetShadowRect(nsIFrame*, StyleAppearance, LayoutDeviceRect&, RectCornerRadii&)

or such, where we can provide a precise rect + radii, and we would avoid
painting the shadow if the function returned false. That would allow us
to remove the native theme box shadow code path, and avoid WR fallback,
all at once.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e01e2b7b4a08 Don't draw focus outlines for box-shadow in the non-native theme. r=mstange
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/303ea40a2e2f Fix test annotation for test that's expected to fail now.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: