1700029 - Clean up MaybeShowOnScreenKeyboard

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

When I have landed bug 1618759, I split newer on screen keyboard code with new class. But old keyboard code (TabTip and VR) is into MayBeShowOnScreenKeyboard. I would like to clean up this for bug 1670539.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1700029 - Part 1. Clean up MaybeShowOnScreenKeyboard. r=masayuki

For bug 1670539, I would like to move each on software keyboard code to
own class at first.

Actually, MaybeShowOnScreenKeyboard handels VR keyboard if VR mode. But
I would like to move VR code to ShowOnScreenKeyboard or own class.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1700029 - Part 2. Move TabTip code to own class. r=masayuki

TabTip's on screen keyboard is for old Windows 10. So I would like to
move this and related code to own class.

Depends on D109259

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1700029 - Part 3. Move VR's software keyboard code to own class. r=masayuki

Depends on D109260

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1700029 - Part 4. Fix build break. r=masayuki

nsDataObj.h uses nsWindowsHelpers.h, but it isn't included.

Depends on D109261

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/107bfcb77389
Part 1. Clean up MaybeShowOnScreenKeyboard. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/8d4c20682890
Part 2. Move TabTip code to own class. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/00883ff82b34
Part 3. Move VR's software keyboard code to own class. r=masayuki

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/107bfcb77389
https://hg.mozilla.org/mozilla-central/rev/8d4c20682890
https://hg.mozilla.org/mozilla-central/rev/00883ff82b34