Closed Bug 1700073 Opened 4 years ago Closed 3 years ago

Implement "WebDriver:GetElementShadowRoot" command

Categories

(Remote Protocol :: Marionette, task, P3)

Default
task

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: whimboo, Assigned: david.burns)

References

(Blocks 3 open bugs, )

Details

Attachments

(1 file, 1 obsolete file)

This bug will be used to implement the given command in Marionette. Details in the spec can be found here:
https://w3c.github.io/webdriver/#get-element-shadow-root

Beside the command it also needs implementations for the element reference type, and the appropriate Shadow DOM related errors.

It would be great to get some basic tests for the Marionette client that just ensure the command is working. Once bug 1700093 is done we will have detailed tests in the webdriver spec suite.

Blocks: 1700093
Blocks: 1700095

This adds the features as described in
https://w3c.github.io/webdriver/#get-element-shadow-root

Depends on D110938

Assignee: nobody → david.burns
Status: NEW → ASSIGNED
Blocks: 1690884

Hi David, I wanted to follow-up with you regarding this bug. Could you maybe give an overview what's left to do? Anything that is specifically blocking you, and you need help with? Thanks a lot.

Flags: needinfo?(david.burns)

:whimboo

This is nearly done. I haven't had chance to debug why it fails with geckodriver.

Could you have a look and see what I have done wrong, I expect it's something really trivial (I hope)

Flags: needinfo?(david.burns) → needinfo?(hskupin)

Sorry for the delay. I was off for a while, and then had a huge backlog. But finally I had a look, and replied on the Phabricator revision itself.

Flags: needinfo?(hskupin)
Attachment #9213806 - Attachment description: WIP: Bug 1700073: Initial implementation of Get Shadow Root in Marionette → Bug 1700073: Initial implementation of Get Shadow Root in Marionette

Hi David, I wanted to check if you would be able to continue on this patch so that we can finish it off. If not please let us know. Thanks!

Flags: needinfo?(david.burns)
Attachment #9213806 - Attachment description: Bug 1700073: Initial implementation of Get Shadow Root in Marionette → Bug 1700073: Add Get Shadow Root to Marionette.
Attachment #9252107 - Attachment is obsolete: true

this is done and now waiting for review

Flags: needinfo?(david.burns) → needinfo?(hskupin)
Blocks: 1743541
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b281ca3301b Add Get Shadow Root to Marionette. r=webdriver-reviewers,jgraham,whimboo
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: needinfo?(hskupin)
Product: Testing → Remote Protocol

As I've noticed today when trying to get a shadow root via the Selenium Python bindings there is a strict assertion still set for Firefox which will not allow users to actually get the shadow root. I've created a PR to get this removed.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: