1700095 - Implement commands "WebDriver:FindElementFromShadowRoot" and "WebDriver:FindElementsFromShadowRoot"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Once bug 1700073 has been implemented and a shadow root element can be used, we need support to find elements within this shadow root.

The specification is at:
https://w3c.github.io/webdriver/#find-element-from-shadow-root
https://w3c.github.io/webdriver/#find-elements-from-shadow-root

It would be great to get some basic tests for the Marionette client that just ensure the command is working. Once geckodriver supports the commands we will get detailed tests in the webdriver spec suite.

Comment 2

[David Burns :automatedtester]

Attachment: Bug 1700095: Add support for finding elements from Shadow Roots to Marionette

This add the marionette parts of

https://w3c.github.io/webdriver/#find-element-from-shadow-root
https://w3c.github.io/webdriver/#find-elements-from-shadow-root

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi David, I would like to ask if you have some updates for us. Or if there is something that I can help with to get this feature added. Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Removing priority so that we can re-triage this bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Should be fine to keep it in the P3 backlog for now unless it's clear that it's really needed.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 8

[Marco Castelluccio [:marco]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adding as tentative bug for our M6 milestone.

Comment 10

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1700095 - [marionette] Add support for finding elements from shadow roots.

Comment 11

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1700095 - [marionette] Move `fromUUID` helper from `WebReference` to `WebElement` class.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2aa71ac3ce
[marionette] Move `fromUUID` helper from `WebReference` to `WebElement` class. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/187b775a1e57
[marionette] Add support for finding elements from shadow roots. r=webdriver-reviewers,jdescottes,whimboo

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7e2aa71ac3ce
https://hg.mozilla.org/mozilla-central/rev/187b775a1e57