1700097 - Implement support for Find Element(s) From Shadow Root

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Once the WebDriver:FindElementFromShadowRoot and WebDriver:FindElementsFromShadowRoot commands are available in Marionette the appropriate support needs to be added to geckodriver.

Tests that need to pass can be found in the Wdspec test suite:

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/find_element_from_shadow_root
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/find_elements_from_shadow_root

Comment 1

[David Burns :automatedtester]

Attachment: Bug 1700097: Add support for get shadow dom root to geckodriver

This adds the necessary pieces for GetShadowRoot from
https://w3c.github.io/webdriver/#get-element-shadow-root

Comment 2

[Phabricator Automation]

Comment on attachment 9213801 [details]
Bug 1700097: Add support for get shadow dom root to geckodriver

Revision D110938 was moved to bug 1700093. Setting attachment 9213801 [details] to obsolete.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is actually the geckodriver bug for finding elements below a shadow root. Getting the shadow root was done in bug 1700093.

Comment 4

[David Burns :automatedtester]

Attachment: Bug 1700097: Add Find Element(s) From Shadow Root APIs to Geckodriver.

This adds the geckodriver parts to

https://w3c.github.io/webdriver/#find-element-from-shadow-root
https://w3c.github.io/webdriver/#find-elements-from-shadow-root

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

David, are you still interested to work on this bug? Thanks.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 8

[Marco Castelluccio [:marco]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adding as tentative bug for our M6 milestone.

Comment 10

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1700097 - [geckodriver] Add support for Find Element(s) From Shadow Root.

Depends on D172225

Comment 11

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1700097 - [wdspec] Add tests for "WebDriver:FindElementFromShadowRoot" and "WebDriver:FindElementsFromShadowRoot".

Depends on D172416

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81fa00900760
[geckodriver] Add support for Find Element(s) From Shadow Root. r=webdriver-reviewers,jgraham,whimboo
https://hg.mozilla.org/integration/autoland/rev/de10522216bc
[wdspec] Add tests for "WebDriver:FindElementFromShadowRoot" and "WebDriver:FindElementsFromShadowRoot". r=webdriver-reviewers,jgraham,whimboo

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39037 for changes under testing/web-platform/tests

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/81fa00900760
https://hg.mozilla.org/mozilla-central/rev/de10522216bc

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham