Closed Bug 1700097 Opened 3 years ago Closed 1 year ago

Implement support for Find Element(s) From Shadow Root

Categories

(Testing :: geckodriver, task, P1)

Default
task
Points:
2

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [webdriver:m6], [wptsync upstream])

Attachments

(3 files, 1 obsolete file)

Once the WebDriver:FindElementFromShadowRoot and WebDriver:FindElementsFromShadowRoot commands are available in Marionette the appropriate support needs to be added to geckodriver.

Tests that need to pass can be found in the Wdspec test suite:

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/find_element_from_shadow_root
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/find_elements_from_shadow_root

Assignee: nobody → david.burns
Status: NEW → ASSIGNED
Attachment #9213801 - Attachment description: WIP: Bug 1700097: Add support for get shadow dom root to geckodriver → Bug 1700097: Add support for get shadow dom root to geckodriver

Comment on attachment 9213801 [details]
Bug 1700097: Add support for get shadow dom root to geckodriver

Revision D110938 was moved to bug 1700093. Setting attachment 9213801 [details] to obsolete.

Attachment #9213801 - Attachment is obsolete: true

This is actually the geckodriver bug for finding elements below a shadow root. Getting the shadow root was done in bug 1700093.

Assignee: david.burns → nobody
Status: ASSIGNED → NEW
Summary: Implement support for Get Element Shadow Root → Implement support for Find Element(s) From Shadow Root
Assignee: nobody → david.burns

David, are you still interested to work on this bug? Thanks.

Priority: -- → P3
Whiteboard: [webdriver:backlog]
Flags: needinfo?(david.burns)
Assignee: david.burns → nobody
Flags: needinfo?(david.burns)
Blocks: 1777689
Assignee: nobody → david.burns
Attachment #9254513 - Attachment description: WIP: Bug 1700097: Add Find Element(s) APIs to Geckodriver. → WIP: Bug 1700097: Add Find Element(s) From Shadow Root APIs to Geckodriver.

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: david.burns → nobody

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → david.burns
Status: NEW → ASSIGNED
Attachment #9254513 - Attachment description: WIP: Bug 1700097: Add Find Element(s) From Shadow Root APIs to Geckodriver. → Bug 1700097: Add Find Element(s) From Shadow Root APIs to Geckodriver.
Assignee: david.burns → nobody
Status: ASSIGNED → NEW
Points: --- → 2
Priority: P3 → P2

Adding as tentative bug for our M6 milestone.

Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m6]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81fa00900760
[geckodriver] Add support for Find Element(s) From Shadow Root. r=webdriver-reviewers,jgraham,whimboo
https://hg.mozilla.org/integration/autoland/rev/de10522216bc
[wdspec] Add tests for "WebDriver:FindElementFromShadowRoot" and "WebDriver:FindElementsFromShadowRoot". r=webdriver-reviewers,jgraham,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39037 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Upstream PR merged by jgraham
Whiteboard: [webdriver:m6], [wptsync upstream] → [webdriver:m6], [wptsync upstream] [webdriver:relnote]
Whiteboard: [webdriver:m6], [wptsync upstream] [webdriver:relnote] → [webdriver:m6], [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: