1700105 - Identify and fix and tests that fail when browser.proton.doorhangers.enabled is true

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

When deriving this list, we should also make sure browser.proton.enabled is true.

We need to do this before enabling Proton, so this is an MR1 blocker.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

mochitest-browser try build with browser.proton.enabled and browser.proton.doorhangers.enabled set to true: https://treeherder.mozilla.org/jobs?repo=try&revision=cc7407df72dc64678057e7e7526125e03d9ee3b9

Comment 2

[Mike Conley (:mconley) (:⚙️)]

According to bug 1700112 comment 0 and bug 1700112 comment 1, there are a number of known failures when browser.proton.enabled is set to true. We're not going to track those in here. I'm going to see if I can filter out the common ones, and identify the list that are only failing when browser.proton.doorhangers.enabled is true.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Top suspects are:

• browser/components/fxmonitor/test/browser/browser_fxmonitor_doorhanger.js
• browser/base/content/test/webrtc/browser_devices_get_user_media.js
• browser/base/content/test/webrtc/browser_devices_get_user_media_default_permissions.js
• browser/base/content/test/webrtc/browser_devices_get_user_media_paused.js
• browser/base/content/test/webrtc/browser_devices_get_user_media_in_xorigin_frame.js
• browser/extensions/formautofill/test/browser/creditCard/browser_anti_clickjacking.js
• browser/base/content/test/general/browser_bug424101.js
• browser/base/content/test/popupNotifications/browser_popupNotification_2.js

Apparently I failed to trigger macOS jobs, so doing that now. Might add more tests here if any macOS-specific ones show up.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1700105 - Fix tests that fail when browser.proton.doorhangers.enabled is true. r?jaws!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/089ac339cd76
Fix tests that fail when browser.proton.doorhangers.enabled is true. r=jaws

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/089ac339cd76