1700957 - Graduate the panels to the main proton pref

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Once bug 1700105, this should be a relatively mechanical find/replace of browser.proton.doorhangers.enabled to browser.proton.enabled.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Once the remaining P1's are closed, is it okay to graduate, or are there other blocking issues before we graduate behind browser.proton.enabled?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Actually, going to redirect that needinfo to tduzan who's been running point on many panels for Product.

Comment 3

[Tyler Duzan]

Just a quick update on this, I am working my way through reviews of the current state of the experience across several platforms. I expect to have a clear answer on this soon. I will ping mconley in Slack with any questions.

Comment 4

[Emma Malysz]

Attachment: Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hey tduzan, since the Proton panels are enabled by default in Nightly, can I presume this bug no longer needs to be P1? "Graduation" at this point is kind of meaningless, at least from an engineering point of view. I suggest downgrading this to a P3.

Comment 6

[Tyler Duzan]

I believe that we could graduate this subpref at this point, as well. The issues that previously prevented that have been resolved.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

True, this can be done, though I don't think it's critical at this point given that the preference is on by default. I think the P3 priority makes sense.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c362512f27b
graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley

Comment 9

[Atila Butkovits]

Backed out for causing failures at test_chrome_only_media_queries.html:
https://hg.mozilla.org/integration/autoland/rev/bf50f2895a27fc44f5f927d3d1952884270f01ae

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=J0WT_RpNTF239yXCn4PROA.0&revision=1c362512f27b58640e4347b753e1975c0fa5fcf1&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64%2Fdebug-mochitest-chrome-1proc%2Cc2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337955422&repo=autoland&lineNumber=4594

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e01ec8694924
graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e01ec8694924

Comment 12

[Sören Hentzschel]

There are still several references to browser.proton.doorhangers.enabled:
https://searchfox.org/mozilla-central/search?q=browser.proton.doorhangers.enabled&case=true&path=

Comment 13

[:Gijs (he/him)]

(In reply to Sören Hentzschel from comment #12)

There are still several references to browser.proton.doorhangers.enabled:
https://searchfox.org/mozilla-central/search?q=browser.proton.doorhangers.enabled&case=true&path=

searchfox is just slow to update - compare that list with the patch linked in comment #11

Comment 14

[Sören Hentzschel]

I didn't check all files but at least StaticPrefList.yaml was not touched at all in the patch and you can also check in about:config that browser.proton.doorhangers.enabled still exists (the patch should be included in the tested Nightly build since setting browser.proton.doorhangers.enabled to false no longer adds the arrow to the panels).

Comment 15

[Emma Malysz]

All files have removed browser.proton.doorhangers.enabled other than StaticPrefList.yaml. I will create a follow up bug for that and the typo Emilio pointed out in https://phabricator.services.mozilla.com/D110135#3688994

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Hey folks,

I've requested the sheriffs to back this out for a few reasons:

1. It looks like there's still a bit left to do (see comment 14)
2. This is lower priority cleanup work that spans a lot of files which might make crafting upliftable patches more difficult, unless this patch gets uplifted (which it probably shouldn't).

It's even unclear if we need to do this work at this point - the panels have effectively graduated by being enabled. It'll probably just be easier to remove all of the branching when we decide to stop supporting the non-Proton variant.

Comment 17

[Natalia Csoregi [:nataliaCs]]

Backout on autoland: https://hg.mozilla.org/integration/autoland/rev/3ee96c3743a066d90178cf32f29f8532a819f577

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1005c275ed0f
Backed out changeset e01ec8694924 as requested. CLOSED TREE

Comment 19

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/3ee96c3743a0

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Given the timeline, plus given bug 1709425 (which aims to remove all of the branching anyways), I think we can WONTFIX this.