1700198 - Remove subviewbutton-iconic class from markup from menus / panels where Proton removes or suppresses them

Status: RESOLVED FIXED

(Firefox :: Menus, task, P3)

Description

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

This class is used to provide icons for some of our menu items. With Proton, we've been removing that class to remove the icons while we transition from pre to post Proton.

Here's an example of where we've done this:

https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/browser/components/customizableui/CustomizableWidgets.jsm#118-127

Once Proton ships, we should remove the class from the markup, rather than doing it via script.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1700198 - Remove subviewbutton-iconic class from Library panel markup. r?mhowell!

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1700198 - Remove subviewbutton-iconic class from Bookmarks panel. r?mak!

Depends on D118621

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1700198 - Remove most subviewbutton-iconic class usage from FxA panel. r?markh!

This also removes code that handled the case where a Send Tab or Send Link to Device
menu needed to be populated when in the STATUS_NOT_CONFIGURED state. Since those menus
should be unavailable when in the STATUS_NOT_CONFIGURED state, we throw instead.

Depends on D118622

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1700198 - Remove subviewbutton-iconic class from History and Synced Tabs panels. r?Gijs!

Depends on D118623

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2744271ea8e
Remove subviewbutton-iconic class from Library panel markup. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/16823e84e6d2
Remove subviewbutton-iconic class from Bookmarks panel. r=mak
https://hg.mozilla.org/integration/autoland/rev/531a73a172ef
Remove most subviewbutton-iconic class usage from FxA panel. r=markh
https://hg.mozilla.org/integration/autoland/rev/df3e9dc2a780
Remove subviewbutton-iconic class from History and Synced Tabs panels. r=Gijs

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f2744271ea8e
https://hg.mozilla.org/mozilla-central/rev/16823e84e6d2
https://hg.mozilla.org/mozilla-central/rev/531a73a172ef
https://hg.mozilla.org/mozilla-central/rev/df3e9dc2a780