Closed Bug 1711508 Opened 5 months ago Closed 3 months ago

Remove PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled smart pref getters and their consumers

Categories

(Firefox :: Toolbars and Customization, task, P3)

Desktop
All
task
Points:
1

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(2 files, 1 obsolete file)

(as noted in bug 1709425, we should not land a patch for this before May 20th, and a patch for bug 1711498 will need to land first)

protonAppMenuEnabled just mirrors the browser.proton.enabled pref. This getter and all its (non-test) consumers should be removed.

protonToolbarEnabled also mirrors this pref, and currently has no non-test consumers - it should be removed, and gProtonToolbarEnabled in CustomizableUI.jsm should also be removed.

Any code that only runs if the getters return false should also be removed. This will need to update the following files (at time of writing - check this searchfox query to ensure more hasn't been added):

browser/base/content/browser-places.js
browser/base/content/browser-sync.js
browser/components/customizableui/CustomizableWidgets.jsm
browser/components/customizableui/CustomizableUI.jsm
browser/components/customizableui/content/panelUI.js
browser/modules/ZoomUI.jsm
browser/components/customizableui/PanelMultiView.jsm
browser/components/customizableui/content/panelUI.js
Whiteboard: [proton-cleanups]
Summary: Remove PanelUI.protonAppMenuEnabled smart pref getter and its consumers → Remove PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled smart pref getters and their consumers

The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Toolbars and Customization
Priority: -- → P3
Severity: -- → N/A
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled.

Points: --- → 1
Attachment #9223570 - Attachment description: Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled r=gijs → WIP: Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled (WIP) r=gijs
Attachment #9223570 - Attachment description: WIP: Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled (WIP) r=gijs → Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled r=mconley

Changes focused on browser-sync.js.

Assignee: bigiri → nobody
Status: ASSIGNED → NEW
Attachment #9223570 - Attachment is obsolete: true
Attachment #9225701 - Attachment is obsolete: true
Depends on: 1700198
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #9225701 - Attachment is obsolete: false
Attachment #9225701 - Attachment description: Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled r=mconley → WIP: Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r?mconley
Blocks: 1719463
Attachment #9225701 - Attachment description: WIP: Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r?mconley → Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r?mconley
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1499e6ca9e3e
remove PanelUI.protonAppMenuEnabled property, r=mconley
https://hg.mozilla.org/integration/autoland/rev/ec3b91cfa28e
remove protonToolbarEnabled property from CustomizableUI, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.