1711508 - Remove PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled smart pref getters and their consumers

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[:Gijs (out for now; he/him)]

(as noted in bug 1709425, we should not land a patch for this before May 20th, and a patch for bug 1711498 will need to land first)

protonAppMenuEnabled just mirrors the browser.proton.enabled pref. This getter and all its (non-test) consumers should be removed.

protonToolbarEnabled also mirrors this pref, and currently has no non-test consumers - it should be removed, and gProtonToolbarEnabled in CustomizableUI.jsm should also be removed.

Any code that only runs if the getters return false should also be removed. This will need to update the following files (at time of writing - check this searchfox query to ensure more hasn't been added):

browser/base/content/browser-places.js
browser/base/content/browser-sync.js
browser/components/customizableui/CustomizableWidgets.jsm
browser/components/customizableui/CustomizableUI.jsm
browser/components/customizableui/content/panelUI.js
browser/modules/ZoomUI.jsm
browser/components/customizableui/PanelMultiView.jsm
browser/components/customizableui/content/panelUI.js

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Bernard Igiri]

Attachment: Bug 1711508 - Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled r=mconley

Removed references to PanelUI.protonAppMenuEnabled and CustomizableUI.protonToolbarEnabled.

Comment 3

[Bernard Igiri]

Attachment: Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r?mconley

Changes focused on browser-sync.js.

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1711508 - remove protonToolbarEnabled property from CustomizableUI, r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1499e6ca9e3e
remove PanelUI.protonAppMenuEnabled property, r=mconley
https://hg.mozilla.org/integration/autoland/rev/ec3b91cfa28e
remove protonToolbarEnabled property from CustomizableUI, r=mconley

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1499e6ca9e3e
https://hg.mozilla.org/mozilla-central/rev/ec3b91cfa28e