1700431 - Factor in syncing state when opening remote tabs and fxa panels

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Emma Malysz]

In Bug 1698492, we always set the data-l10n-id to the "Sync now" default:
https://searchfox.org/mozilla-central/rev/1758450798ae14492ba28b695f48143840ad6c5b/browser/base/content/browser-sync.js#543-544
https://searchfox.org/mozilla-central/rev/1758450798ae14492ba28b695f48143840ad6c5b/browser/components/customizableui/CustomizableWidgets.jsm#619-620

However, we can be mid-sync and sometimes should have the "Syncing" label instead.
We should check for the "active" state on the sync now button.

Comment 1

[Emma Malysz]

Attachment: Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1698492

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92258b0f6af7
take syncing state into account when setting datal10nid for sync now buttons r=Gijs

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/92258b0f6af7

Comment 5

[Emma Malysz]

Comment on attachment 9211109 [details]
Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons

Beta/Release Uplift Approval Request

• User impact if declined: Label on "Sync now" button can be incorrect
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: *With proton enabled and signed into fxa

1. Open firefox
2. Open fxa panel
3. Observe button label is "Syncing..." with a blue rotating icon
4. Close panel
5. Open panel again. If still syncing, it should be the same as step 3. If no longer syncing, it should say "Sync Now" with no icon.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes
• String changes made/needed: n/a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211109 [details]
Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons

Approved for 88.0b3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/870d04e7f125

Comment 8

[Rares Doghi, Desktop QA]

This issue is verified as fixed in Beta 88.0b3 and our latest Nightly build 89.0a1 (2021-03-26) on Windows 10, Mac OsX 11.0 and Ubuntu 20.04.