1700467 - Default theme ignores Windows 10 accent color from version 88

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Jan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

I've updated to Firefox 88.0b1 (64-bit) on Windows 10, where I have "Title bars and window borders" turned on for using the system accent color.

Actual results:

The "Default" Firefox theme includes a black bar behind tabs, the same way as the "Dark theme".

Expected results:

The tab bar should be the color of system accent color. This was the behavior as of Firefox 87 and lower.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Andrei Purice]

Hey Jan,
I tried reproducing this issue on the latest versions of Firefox Nightly 89.0a1 (2021-03-24), beta 88.0b2 and release 87.0 but i can't see the black bar and the tab bar is the exact color of the system.

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 3

[Jan]

Attachment: new profile screenshot with orange system accent

Comment 4

[Jan]

Attachment: orange accent switches font to black and the black bar makes text invisible

Comment 5

[Jan]

Safe mode and new profile did not resolve the issue. Persists on 88.0b2.

See screenshots from the new profile - striking orange accent color configured.

Comment 6

[Jan]

Attachment: Nightly 89.0a1 (2021-03-24)

Comment 7

[Jan]

Attachment: Firefox 87 with correct behavior

Comment 8

[Jan]

Using Windows 10 Enterprise 20H2, build 19042.870

Comment 9

[Jan]

Any updates please? Still an issue 2 weeks later on latest beta (88.0b7) and Nightly [89.0a1 (2021-04-05)]. With a striking accent color, like the orange in examples above, the GUI looks broken with black font on black background for inactive tabs.

Comment 10

[Tracy Walker [:tracy]]

Jared, could this be Proton related?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: image.png

Hm, I'm unable to reproduce this with mozregression. We are removing support for titlebar color in Firefox 89 and it's possible that this change accidentally made it into Firefox 88. I'm still digging here.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Ah, okay this requires the system also be set to Dark mode...

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: The titlebar should still show the accent color in Firefox 88 as well in Firefox 89 when Proton is disabled. This is making background tabs unreadable.

Comment 14

[Harry Twyford]

Attachment: Bug 1700467 - Restore accent colors in the titlebar on Windows 10. r?jaws!

This would also be fixed by adding -moz-windows-accent-color-in-titlebar media queries. However, by changing this behaviour for all Windows 10 users, we also fix bug 1703546. After the Proton pref is removed, we can remove these two new media queries, since we will no longer use the accent color in the titlebar on Windows.

Comment 15

[Harry Twyford]

Comment on attachment 9216217 [details]
Bug 1700467 - Restore accent colors in the titlebar on Windows 10. r?jaws!

Beta/Release Uplift Approval Request

• User impact if declined: We'd lose support for accent colors in title bars on Windows in Firefox 88. The bug reporter also reports that text loses contrast when Accent colors in title bars is set, although I could not reproduce that myself.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA should test this fix, but I don't think it should block uplift. :jaws and I already verified the fix on our machines.

To reproduce:

1. Set the Windows theme to Dark.
2. Enable showing accent colours in title bars (it's a system level toggle in Windows 10's Color settings)

If the fix works, the accent color will be shown in the tabs bar.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS fix
• String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9216217 [details]
Bug 1700467 - Restore accent colors in the titlebar on Windows 10. r?jaws!

Approved for 88.0rc2, thanks.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/38ee7c9c51c5

Comment 18

[Harry Twyford]

Attachment: Bug 1700467 - Hotfix - Update other instance of backgroundColorSetOnRoot to fix a test failure. r?jaws!

Comment 19

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I was able to reproduce the issue on 88.0b1 under Windows 10 by using the informations from Comment 0 and Comment 15.

The accent color is back on 88.0 RC2.

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/ac496b5bd85d