Closed Bug 1594132 Opened 2 years ago Closed 3 months ago

Find a solution for lwtheme mode that allows vibrancy in sidebars

Categories

(Firefox :: Theme, defect, P3)

All
macOS
defect
Points:
3

Tracking

()

RESOLVED FIXED
88 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Status
firefox-esr78 --- disabled
firefox71 --- unaffected
firefox72 --- disabled
firefox73 --- disabled
firefox74 --- disabled
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- fixed

People

(Reporter: mstange, Assigned: harry)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

In bug 1592739 I'm turning off the vibrancy effect for sidebars when a lightweight theme is in use. The reason for that is that the root element has a CSS background-color in lwtheme mode, and vibrancy now only works if nothing is rendered behind the vibrant element.

If we can stop lwthemes from giving the root element a background, and instead set the background on other parts of the window (e.g. the toolbox), then we can re-enable vibrancy for sidebars.

Type: enhancement → defect
Keywords: regression
Priority: -- → P3
Regressed by: 1592739
Regressed by: 1644461
No longer regressed by: 1592739
See Also: → 1672081
See Also: → 1651476
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 87.2 - Feb 8 - Feb 21
Points: --- → 2
Attachment #9201814 - Attachment description: Bug 1594132 - Find a solution for lwtheme mode that allows vibrancy in sidebars → Bug 1594132 - Move background-color rules so they do not appear under appearance rules, enabling sidebar vibrancy.

This involves significantly more test changes than I was expecting.

Points: 2 → 3
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5ee2e40acc0
Move background-color rules so they do not appear under appearance rules, enabling sidebar vibrancy. r=ntim,dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1694734
Depends on: 1699097
Regressions: 1703546
You need to log in before you can comment on or make changes to this bug.