170070 - wrong parsing of dates in ftp-listings in mozilla 1.2alpha

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Roy-Magne Mo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020913
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020913

Seems like the parsing of dates in ftp-listing has a flawed algoritm. 

Reproducible: Always

Steps to Reproduce:
1. enter ftp://ftp.mozilla.org/
2.
3.

Actual Results:  
I'm attaching a screenshot to document the issue

Expected Results:  
correctly parsed the date

Comment 1

[Roy-Magne Mo]

Does not seem to be a locale dependant issue. 

System is Redhat 7.3 with gnome2

Comment 2

[Roy-Magne Mo]

Attachment: screenshot of ftp listing bug

Comment 3

[Stefan [:stefanh]]

Confirming with Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.2a) Gecko/20020910
build 2002091014. Just looks slightly different, see attached screenshot.

Comment 4

[Stefan [:stefanh]]

Attachment: screenshot of ftp listing bug on Mac

Comment 5

[Andrew Schultz]

*** Bug 170076 has been marked as a duplicate of this bug. ***

Comment 6

[Andrew Schultz]

confirming with linux trunk build 20020919
this look like a regression from bug 95590 (regression between builds 2002082722
and 2002082904)

Comment 7

[benc]

CONFIRMED, win98, mozilla 1.2a
The dates simply don't show up for the bad entries.

Comment 8

[benc]

+nsbeta1, allplats

Comment 9

[Doug Turner (:dougt)]

Attachment: patch v.1

ParseFTPList doesn't need to worry about y2k roll over because NSPR does this
for us.  ParseFTPList use to use libc time.

Comment 10

[neeti]

Comment on attachment 100231 [details] [diff] [review]
patch v.1

r=neeti

Comment 11

[Darin Fisher]

Comment on attachment 100231 [details] [diff] [review]
patch v.1

sr=darin

Comment 12

[Doug Turner (:dougt)]

thanks.  Fixed checked into trunk.

Checking in ParseFTPList.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/ParseFTPList.cpp,v  <-- 
ParseFTPList.cpp
new revision: 1.2; previous revision: 1.1
done

Comment 13

[Dawn Endico]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20020925

works for me now with today's linux and osx builds.

Comment 14

[Boris Zbarsky [:bzbarsky]]

*** Bug 172043 has been marked as a duplicate of this bug. ***

Comment 15

[Eric Hanchrow]

*** Bug 172137 has been marked as a duplicate of this bug. ***