1700715 - With native context menus enabled, the context menu of the bookmarks toolbar has strange contents (too many items, or duplicate items, or empty items, or all items disabled)

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

Attachment: example screenshot

Steps to reproduce:

1. Be on macOS, and set widget.macos.native-context-menus and browser.proton.contextmenus.enabled to true.
2. Make sure the bookmarks toolbar is shown.
3. Right-click on a bookmark or a bookmarks folder in the bookmarks toolbar.

Expected results:
The context menu should contain the items you would expect, and the right items should be enabled.

Actual results:
The menu has odd contents.

Note: If you set one of the prefs to false, open the non-native context menu, and then set them to true again, the native context menu will now contain the correct contents. In that case you can open a new window to reproduce this bug again.

Comment 1

[Markus Stange [:mstange]]

With document.popupNode returning something sensible during popupshowing, this is mostly fixed. There's one remaining issue with add-on items being re-added at the end of the popup repeatedly, but I'll file a new bug about that.

Comment 2

[Sören Hentzschel]

FYI: The same happens in the bookmarks sidebar. Not sure if there will be one fix for both or if it will need a own fix so I wanted to leave a comment here.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1700715 - Make document.popupNode work during the popupshowing event for native menus. r=tnikkel

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1700715 - Make sure popuphiding / popuphidden are fired even when a NativeMenu is destroyed while it's open. r=harry

This scenario is encountered when the same menu is opened again while it's already open:
nsMenuPopupFrame::InitializePopupAsNativeContextMenu overwrites mNativeMenu with a newly-created
NativeMenu, destroying the old one before it had a chance to fire its popuphiding/popuphidden events.
One place where we do this is if you right-click in the bookmarks bar and then, while the menu is
open, right-click again on the bookmarks bar in a different place.

Since we weren't dispatching popuphiding/popuphidden events for the first menu in this scenario
before this patch, some menu items would be duplicated because their old versions were never removed.

Depends on D110141

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e238ae1076b5
Make document.popupNode work during the popupshowing event for native menus. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/35ad58e648ac
Make sure popuphiding / popuphidden are fired even when a NativeMenu is destroyed while it's open. r=harry

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d81d522f8b5e
Make document.popupNode work during the popupshowing event for native menus. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/80d0a471b517
Make sure popuphiding / popuphidden are fired even when a NativeMenu is destroyed while it's open. r=harry

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6612df1d6fcd
Backed out 2 changesets as per dev's request

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d81d522f8b5e
https://hg.mozilla.org/mozilla-central/rev/80d0a471b517

Comment 9

[Emil Ghitta, QA [:emilghitta]]

Reproduced the issue mentioned in comment 0 using Firefox 89.0a1 (build from 2021-03-24).

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on macOS 10.15 with native menus enabled.