Make `--backgroundtask` temporary profiles truly random
Categories
(Toolkit :: Application Update, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | unaffected |
| firefox87 | --- | wontfix |
| firefox88 | --- | wontfix |
| firefox89 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
Right now, the --backgroundtask temporary profile name is deterministic. This clashes across installations, and only works if we always delete the profile on exit, which is fragile. This ticket tracks injecting the installation hash (for easy identification) and some randomness (for concurrent background tasks) into the profile path.
|
||
Comment 1•3 years ago
|
||
|
|
||
Comment 2•3 years ago
|
||
Set release status flags based on info from the regressing bug 1667276
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 3•3 years ago
|
||
It's very unlikely that this would make a difference, since creating
the service does not immediately look for a profile. But it's also
not clear to me why I originally placed it after the service was
created, and it's not impossible that the service creation would look
for XRE_PROFILE_PATH (which is how we communicate the desired
profile to the profile service), so let's create the profile before
the service.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D110309
|
|
Assignee | |
Comment 5•3 years ago
|
||
A fairly comprehensive mochitest try build is percolating at https://treeherder.mozilla.org/jobs?repo=try&revision=f612c22848cd0c06330dd9cf3e1a8ba92f91ab85.
|
|
Assignee | |
Comment 6•3 years ago
|
||
When --backgroundtask TASK invocations exit, they try to remove
their temporary profile directory. This mostly works, except there
are some very late writes to the profile directory including
Telemetry.ShutdownTime.txt and the security_state directory. This
commit accommodates by moving the profile directory removal even
later. It might be possible to instead avoid these very late writes,
but that is hard in general, and is more likely to depend on the exact
code invoked by the background task itself.
It's not clear to me how I/O imposition and/or late write checking
will interact with this: guidance appreciated!
Depends on D110310
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 7•3 years ago
|
||
When --backgroundtask TASK invocations exit, they try to remove
their temporary profile directory. This mostly works, except there
are some very late writes to the profile directory including
Telemetry.ShutdownTime.txt and the security_state directory. This
commit accommodates by moving the profile directory removal even
later. It might be possible to instead avoid these very late writes,
but that is hard in general, and is more likely to depend on the exact
code invoked by the background task itself.
It's not clear to me how I/O imposition and/or late write checking
will interact with this: guidance appreciated!
Depends on D110310
|
|
||
Updated•3 years ago
|
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3825a9d1a1e0 Pre: Create backgroundtask temporary profile before profile service. r=mossop https://hg.mozilla.org/integration/autoland/rev/77f3a6691c8d Part 1: Make temporary background profiles per-installation and unique. r=bytesized,mossop https://hg.mozilla.org/integration/autoland/rev/fe8189e76358 Part 2: Remove temporary background profile directories very late. r=dthayer
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3825a9d1a1e0
https://hg.mozilla.org/mozilla-central/rev/77f3a6691c8d
https://hg.mozilla.org/mozilla-central/rev/fe8189e76358
|
||
Updated•3 years ago
|
Description
•