1689519 - Add `--backgroundtask backgroundupdate` implementation

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks adding a Gecko-based background task using the framework of Bug 1667276 that pumps UpdateService.jsm.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Add AppUpdater.jsm helpers: terminal predicate, debug string. r?adw

The AppUpdater module invokes a callback with updater status codes.
The callback can be invoked multiple times with different codes
throughout the lifecycle of an update (check). This helper captures
the codes that are terminal, meaning that the update (check) has
completed. It also includes a tiny helper to determine a string
representation of a status code for logging.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Add `--backgroundtask backgroundupdate`. r?bytesized

This background task checks various eligibility criteria and then
pumps the App Update Service update loop.

For convenience, it uses the existing browser-only AppUpdater.jsm.
There's nothing truly browser-specific here, though; in the future, we
could support other applications (namely, Thunderbird).

Depends on D104637

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Add BackgroundTasksManager.EXIT_CODE. r?bytesized

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Extract Windows install information to a reusable module. r?agashlin

There was some subtle logic around counting installs and our own path
(remember, this can be used from an unarchived package that itself was
not installed from the Windows installer) that I didn't care to keep;
this does the simplest possible thing instead.

Depends on D108661

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Assume user can't elevate in background task mode. r?bytesized

Depends on D108661

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Separate `canX` from `canUsuallyX` in Update Service. r?bytesized

The canUsuallyX variants do not take into account transient factors.
The set of transient factors may evolve over time, so we don't list
them exhaustively, but they may include:

1. Whether this instance has the update mutext (on Windows);
2. Whether other instances are running.

The intended consumer of these variants is the background update task
machinery, which wants to schedule tasks when they are likely to
usually succeed, even if they might not succeed right now.

Depends on D108701

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1689519 - Pre: Expose `MOZ_APP_DISPLAYNAME_DO_NOT_USE` in AppConstants. r?#build

My immediate use case is making the name for a Windows Scheduled Tasks
agree with the existing task names for the Windows Default Browser
Agent task name. The latter uses MOZ_APP_DISPLAYNAME in its static
metadata and from C++.

We want to strongly discourage users from using MOZ_APP_DISPLAYNAME
in dynamic contexts, hence the unusual name and long comment; but it's
not worth establishing a lint limiting uses at this time.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/673745818480
Pre: Add BackgroundTasksManager.EXIT_CODE. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/94fcfdd28dbd
Pre: Assume user can't elevate in background task mode. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/587a4c4aa10d
Pre: Separate `canX` from `canUsuallyX` in Update Service. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/cd5b5cc01886
Pre: Add AppUpdater.jsm helpers: terminal predicate, debug string. r=adw,bytesized
https://hg.mozilla.org/integration/autoland/rev/06ddd32322a9
Pre: Expose `MOZ_APP_DISPLAYNAME_DO_NOT_USE` in AppConstants. r=glandium,Kwan
https://hg.mozilla.org/integration/autoland/rev/7d67c1219118
Add `--backgroundtask backgroundupdate`. r=bytesized

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/673745818480
https://hg.mozilla.org/mozilla-central/rev/94fcfdd28dbd
https://hg.mozilla.org/mozilla-central/rev/587a4c4aa10d
https://hg.mozilla.org/mozilla-central/rev/cd5b5cc01886
https://hg.mozilla.org/mozilla-central/rev/06ddd32322a9
https://hg.mozilla.org/mozilla-central/rev/7d67c1219118