Closed Bug 1700891 Opened 4 years ago Closed 4 years ago

Migrate new install warning to Fluent

Categories

(Toolkit :: Startup and Profile System, task)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 obsolete file)

It's only one of two places using the DTD brand for Firefox Account, we should move it to Fluent.

From bug 1518632

Note that I attempted to implement the modal dialog using html but it turns out to be very difficult to get a dialog sized correctly using html. Something we should investigate and fix elsewhere.

I also attempted to use fluent for the localization of the dialog and even with XUL hit sizing issues. Because fluent runs after layout the dialog would size assuming it had no content. It was possible to resize after fluent ran but then you see the size change visibly.

@zibi
Would you have any idea if and how this could be solved?

Flags: needinfo?(zbraniecki)

Clearing NI for now. I've tested locally with Services.ww.openWindow(window, "chrome://browser/content/newInstall.xhtml", "_blank", "chrome,modal,resizable=no,centerscreen", null); (thanks to Gijs for the help), but the dialog seems to respond without issues to size changes in the FTL file.

I'm going to redirect the r? to :mossop, to see if he can still replicate the issue he had.

Flags: needinfo?(zbraniecki)
Attachment #9211454 - Attachment is obsolete: true

Wontfixing, since this UI is going to be removed in bug 1700972.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
See Also: → 1700972
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: