1700972 - Remove profile-per-install onboarding UI

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

Attachment: Onboarding screenshot

It has been nearly two years since we implemented profile per install but we are still showing users the attached onboarding experience when they run a new install of Firefox. I think at this point the behaviour is established enough that we can remove this, what do you think Romain?

Comment 1

[Romain Testard [:RT]]

Can you please refresh my memory on the exact condition this gets displayed?
ALso quantifying when it happens, I have this query but can you please confirm the "scalar_parent_startup_profile_selection_reason" the scenario here maps to? https://sql.telemetry.mozilla.org/queries/63029/source#161642

Comment 2

[Dave Townsend [:mossop]]

(In reply to Romain Testard [:RT] from comment #1)

Can you please refresh my memory on the exact condition this gets displayed?

This happens when starting an install of Firefox for the first time that is either brand new or has been upgraded from a version prior to 67 (released May 21st 2019) and there is already a different install of Firefox on the computer which has claimed the old-style (not per-install) default profile. Then we create a new profile for this install and display this UI on startup. The intent was to show users who had multiple Firefox installs which would have all used the same default profile previously an explanation for why different installs were now getting different profiles.

ALso quantifying when it happens, I have this query but can you please confirm the "scalar_parent_startup_profile_selection_reason" the scenario here maps to? https://sql.telemetry.mozilla.org/queries/63029/source#161642

Ah yes I had forgotten about that telemetry, this is firstrun-skipped-default or restart-skipped-default. The restart case would most likely be following an auto-update from Firefox <67 so unsurprisingly the number there is tiny, 27. The other is likely new installs of Firefox and that is at 14,700, which looks to be less than 0.001%.

Now this isn't causing any maintenance hassle that I'm aware of so there isn't any issue with leaving it in, I'm just not sure the message it is giving is correct for the current circumstances. It was really written in mind of explaining what happens as users upgraded and so the modal was important. Now it mostly happens when a user installs a new Firefox.

Comment 3

[Romain Testard [:RT]]

Thanks for the details!
I agree that circumstances are now different and users installing Firefox should expect that a new install of Firefox would have a fresh new profile. I'm fine with removing this.

Comment 4

[Francesco Lodolo [:flod]]

Note: please also remove browser/locales/en-US/chrome/browser/syncBrand.dtd as part of this patch. This page should be the last consumer of &syncBrand.fxAccount.label, after bug 1702118 lands.
https://searchfox.org/mozilla-central/search?q=syncBrand&path=&case=false&regexp=false

Comment 5

[Francesco Lodolo [:flod]]

Any chance we could target this in 90? My main concern is making sure it doesn't end up in the next ESR, otherwise we'll need to support it for another 9 months in our localization toolchain.

Comment 6

[Dave Townsend [:mossop]]

https://treeherder.mozilla.org/jobs?repo=try&revision=4533696342f2ea5224427a8dd49f0d9e0811ca9d

Comment 7

[Dave Townsend [:mossop]]

Attachment: Bug 1700972: Remove profile-per-install onboarding UI. r=Gijs

Comment 8

[Dave Townsend [:mossop]]

(In reply to Francesco Lodolo [:flod] from comment #5)

Any chance we could target this in 90? My main concern is making sure it doesn't end up in the next ESR, otherwise we'll need to support it for another 9 months in our localization toolchain.

Yes, sorry I had meant to push this up earlier in the week. I see a string freeze starts tomorrow so I suspect we can't get this into 89 but will land it after the merge.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Dave Townsend [:mossop] from comment #8)

(In reply to Francesco Lodolo [:flod] from comment #5)

Any chance we could target this in 90? My main concern is making sure it doesn't end up in the next ESR, otherwise we'll need to support it for another 9 months in our localization toolchain.

Yes, sorry I had meant to push this up earlier in the week. I see a string freeze starts tomorrow so I suspect we can't get this into 89 but will land it after the merge.

I would definitely merge this after merge day. This won't have a practical impact before we drop ESR78 from our systems, so 90 is more than enough.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea3e4e639ef6
Remove profile-per-install onboarding UI. r=Gijs

Comment 11

[Dave Townsend [:mossop]]

Attachment: Bug 1700972: Remove now unreferenced horizontal-lockup.svg

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f06480a3358b
Remove now unreferenced horizontal-lockup.svg

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ea3e4e639ef6
https://hg.mozilla.org/mozilla-central/rev/f06480a3358b