Closed Bug 1700941 Opened 3 years ago Closed 3 years ago

[Proton] Long strings are overlapping the drop down arrow in the username's field

Categories

(Toolkit :: Password Manager, defect, P1)

Product:
Toolkit
Component:
Password Manager
Version:
Firefox 89
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: cgeorgiu, Assigned: itiel_yn8)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-door-hangers])

Attachments

(2 files)

image (1).png
2.78 KB, image/png
Details
Bug 1700941 - Don't overlap long text with the arrow icon in the username field, in the password panel r?emalysz
48 bytes, text/x-phabricator-request
Details | Review
Attached image image (1).png —

Affected versions

  • latest Nightly 89.0a1

Affected platforms

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 20.04 x64

Steps to reproduce

  1. Launch Firefox and set the browser.proton.doorhangers.enabled and browser.proton.enabled to true.
  2. Go to facebook.com, enter some random credentials on the login page, so that the password panel appear.
  3. Enter some long strings in the username field.

Expected result

  • The drop down arrow is not overlapping the string.

Actual result

  • The drop down arrow is overlapping the string.

Suggested Severity

  • S4, since this is an edge case scenario. I doubt that users will have such long usernames.

Regression range

  • Last good revision: 9ba9e2a1353535edf26072ebbcba4af50df5beea

Additional notes

  • please see the attached screenshot.
  • the issue is not reproducible with proton disabled.
Priority: -- → P2

Triaging to 2A due to it being a regression introduced by MR1. We should fix this if possible before shipping.

Whiteboard: [proton-door-hangers][priority:2a]

This also covers the case where the user may change text direction in the input.

Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED

Promoted to P1 per conversation in MR1 triage call this morning

Blocks: 1700957
Priority: P2 → P1
Whiteboard: [proton-door-hangers][priority:2a] → [proton-door-hangers]
Attachment #9214490 - Attachment description: Bug 1700941 - Don't overlap long text with the arrow icon in the uesrname field, in the password panel r?emalysz → Bug 1700941 - Don't overlap long text with the arrow icon in the username field, in the password panel r?emalysz
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/b0fc6858270d
Don't overlap long text with the arrow icon in the username field, in the password panel r=emalysz

https://hg.mozilla.org/mozilla-central/rev/b0fc6858270d

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

The issue is verified as fixed on latest Nightly 89.0a1, under macOS 10.15, Win 10 x64 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: