1700993 - Ensure fxa button in app menu has correct labels when disconnected or finishing account setup

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Emma Malysz]

Attachment: Screen Shot 2021-03-25 at 9.24.11 AM.png

When the account has been disconnected and we restart the browser, we need to update the fxa app menu button. I've attached an image of what it currently displays. We will run into the same issue for "finish account setup".

The disconnected prompt should:

1. Introduce a new string: "You've been disconnected"
2. Bold the email underneath
3. Have a yellow warning icon
4. Have the subviewbutton-nav class
   Without a browser restart, we are just shown "Account disconnected" without the "Sync and save data" label. Either way, we're going to need to adjust it.

The finish account setup prompt should:

1. Use the "Finish Account setup" string, unbolded
2. Bold the email underneath
3. Have a yellow warning icon
4. Have the subviewbutton-nav class
   We're going to need to make sure to hide "Sync and save data" label here too.

I suggest P1, but feel free to adjust.

Comment 1

[Emma Malysz]

Attachment: Bug 1700993, adjust app menu fxa button for different states.

This patch:
-displays the correct fxa button in the app menu when
unverified or disconnected
-shows the "sign out" button in the fxa panel for the above states
-introduces a new string for a disconnected state
-strengthens our test coverage for the proton fxa panel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2c9db311901
adjust app menu fxa button for different states. r=fluent-reviewers,flod,markh

Comment 3

[Julien Chaupitre]

@rtestard, can you please prioritize this bug.

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f2c9db311901

Comment 6

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly build 89.0a1 (build id: 20210330215136) using Windows 10, Windows 7 (with low resolution), MacOS 10.15 and Ubuntu 18.04.