1701000 - Remove the sync logins infobar

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Mark Striemer [:mstriemer]]

The sync logins infobar [1] is more of an advertisement than an infobar and should be removed. Ideally we'd remove the code but if that's too difficult we can force the signon.management.page.showPasswordSyncNotification to disable the infobar.

[1] https://searchfox.org/mozilla-central/rev/6c9ff2820d3aae683ec87c53c79e5108d54f3f76/browser/components/aboutlogins/AboutLoginsParent.jsm#664

Comment 1

[Francesco Lodolo [:flod]]

Shouldn't this be in Firefox :: about:logins?

It would be great to remove it, more than disabling it, because these strings are getting in the way of removing the Sync brands (bug 1700638). I tried to look into it, but there's simply too much code for me to remove it safely.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'll see if I can knock this out.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1701000 - Remove the sync logins CTA infobar. r?sfoster!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f5ab15651a0
Remove the sync logins CTA infobar. r=fluent-reviewers,flod,dimi

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3f5ab15651a0

Comment 6

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 89 beta 2 and the latest Nightly 90.0a1 - the Sync Login Infobar is no longer displayed. Verified on macOS BigSur 11.2, Windows 10 x64 and Ubuntu 20.04, and Proton on and off.