Closed Bug 1701000 Opened 9 months ago Closed 8 months ago

Remove the sync logins infobar

Categories

(Firefox :: Messaging System, task, P2)

task

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: mstriemer, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-infobars])

Attachments

(1 file)

The sync logins infobar [1] is more of an advertisement than an infobar and should be removed. Ideally we'd remove the code but if that's too difficult we can force the signon.management.page.showPasswordSyncNotification to disable the infobar.

[1] https://searchfox.org/mozilla-central/rev/6c9ff2820d3aae683ec87c53c79e5108d54f3f76/browser/components/aboutlogins/AboutLoginsParent.jsm#664

Shouldn't this be in Firefox :: about:logins?

It would be great to remove it, more than disabling it, because these strings are getting in the way of removing the Sync brands (bug 1700638). I tried to look into it, but there's simply too much code for me to remove it safely.

I'll see if I can knock this out.

Assignee: nobody → mconley
Priority: P1 → P2
Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f5ab15651a0
Remove the sync logins CTA infobar. r=fluent-reviewers,flod,dimi
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified as fixed using the latest Firefox 89 beta 2 and the latest Nightly 90.0a1 - the Sync Login Infobar is no longer displayed. Verified on macOS BigSur 11.2, Windows 10 x64 and Ubuntu 20.04, and Proton on and off.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.