1701001 - Standardize the condition for opening popup from window.open, and BarProp values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Tooru Fujisawa [:arai]]

https://github.com/whatwg/html/issues/5872 is about standardizing when a popup is opened by window.open call.
https://github.com/whatwg/html/issues/4431 is about standardizing what value window's BarProp attributes (window.locationbar.visible etc) returns.

Draft proposal for fixing those issues in https://arai-a.github.io/window-open-features/proposal.html
I'll open spec and test PRs within a few days and post the URLs here.

the condition for opening popup is different than the current Firefox behavior (the proposal is based on Safari), so that part requires change.
BarProp values in the proposal are also different than the current Firefox behavior (they based on Chromium), so that part also requires change.

Comment 1

[Tooru Fujisawa [:arai]]

WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=223751
Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1192701

Comment 2

[Tooru Fujisawa [:arai]]

Spec PR: https://github.com/whatwg/html/pull/6530
test PR: https://github.com/web-platform-tests/wpt/pull/28243

Comment 3

[Tooru Fujisawa [:arai]]

Now the proposal uses popup feature that can explicitly specify whether to request popup or non-popup.

we have conflicting chrome-only popup feature.
we need to either:

• handle the popup feature differently between chrome vs content
• rename existing popup to something else
• consolidate the popup behavior between them

Comment 4

[Tooru Fujisawa [:arai]]

We should be able to handle the chrome-only popup feature and content-only popup feature separately,
depending on the context.
So I'll go with the first option.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1701001 - Part 1: Standardize the condition for opening popup from window.open. r?smaug!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1701001 - Part 2: Add "is popup" field to browsing context. r?smaug!

Depends on D129410

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1701001 - Part 3: Standardize the BarProp values. r?smaug!

Depends on D129411

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e2ca3cc650e
Part 1: Standardize the condition for opening popup from window.open. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b0e47b1f4d39
Part 2: Add "is popup" field to browsing context. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ff439d9c0391
Part 3: Standardize the BarProp values. r=smaug

Comment 9

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1737832, Bug 1701001) for causing geckoview failures on noopener-noreferrer-BarProp.window.html.
Backout link
Push with failures
Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1acae799749
Part 1: Standardize the condition for opening popup from window.open. r=smaug
https://hg.mozilla.org/integration/autoland/rev/eea9fe1bf6ea
Part 2: Add "is popup" field to browsing context. r=smaug
https://hg.mozilla.org/integration/autoland/rev/0de6f75576d0
Part 3: Standardize the BarProp values. r=smaug

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f1acae799749
https://hg.mozilla.org/mozilla-central/rev/eea9fe1bf6ea
https://hg.mozilla.org/mozilla-central/rev/0de6f75576d0

Comment 12

[Tooru Fujisawa [:arai]]

opened PR for MDN

• https://github.com/mdn/content/pull/10339
• https://github.com/mdn/browser-compat-data/pull/13322