Standardize the condition for opening popup from window.open, and BarProp values
Categories
(Core :: DOM: Core & HTML, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug, )
Details
Attachments
(3 files)
https://github.com/whatwg/html/issues/5872 is about standardizing when a popup is opened by window.open
call.
https://github.com/whatwg/html/issues/4431 is about standardizing what value window's BarProp
attributes (window.locationbar.visible
etc) returns.
Draft proposal for fixing those issues in https://arai-a.github.io/window-open-features/proposal.html
I'll open spec and test PRs within a few days and post the URLs here.
the condition for opening popup is different than the current Firefox behavior (the proposal is based on Safari), so that part requires change.
BarProp
values in the proposal are also different than the current Firefox behavior (they based on Chromium), so that part also requires change.
Assignee | ||
Comment 1•4 years ago
|
||
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=223751
Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1192701
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 3•3 years ago
•
|
||
Now the proposal uses popup
feature that can explicitly specify whether to request popup or non-popup.
we have conflicting chrome-only popup
feature.
we need to either:
- handle the
popup
feature differently between chrome vs content - rename existing
popup
to something else - consolidate the
popup
behavior between them
Assignee | ||
Comment 4•3 years ago
|
||
We should be able to handle the chrome-only popup
feature and content-only popup
feature separately,
depending on the context.
So I'll go with the first option.
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Comment 6•3 years ago
|
||
Depends on D129410
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D129411
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 9•3 years ago
•
|
||
Backed out 4 changesets (Bug 1737832, Bug 1701001) for causing geckoview failures on noopener-noreferrer-BarProp.window.html.
Backout link
Push with failures
Failure Log
Comment 10•3 years ago
|
||
Comment 11•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f1acae799749
https://hg.mozilla.org/mozilla-central/rev/eea9fe1bf6ea
https://hg.mozilla.org/mozilla-central/rev/0de6f75576d0
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 12•3 years ago
|
||
Description
•