Closed Bug 1701001 Opened 4 years ago Closed 3 years ago

Standardize the condition for opening popup from window.open, and BarProp values

Categories

(Core :: DOM: Core & HTML, task, P2)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug, )

Details

Attachments

(3 files)

https://github.com/whatwg/html/issues/5872 is about standardizing when a popup is opened by window.open call.
https://github.com/whatwg/html/issues/4431 is about standardizing what value window's BarProp attributes (window.locationbar.visible etc) returns.

Draft proposal for fixing those issues in https://arai-a.github.io/window-open-features/proposal.html
I'll open spec and test PRs within a few days and post the URLs here.

the condition for opening popup is different than the current Firefox behavior (the proposal is based on Safari), so that part requires change.
BarProp values in the proposal are also different than the current Firefox behavior (they based on Chromium), so that part also requires change.

Severity: -- → N/A
Priority: -- → P2
Depends on: 1710010
See Also: → 1714939

Now the proposal uses popup feature that can explicitly specify whether to request popup or non-popup.

we have conflicting chrome-only popup feature.
we need to either:

  • handle the popup feature differently between chrome vs content
  • rename existing popup to something else
  • consolidate the popup behavior between them

We should be able to handle the chrome-only popup feature and content-only popup feature separately,
depending on the context.
So I'll go with the first option.

Depends on: 1737832
Blocks: 1714939
Attachment #9247573 - Attachment description: WIP: Bug 1701001 - Part 1: Standardize the condition for opening popup from window.open. → WIP: Bug 1701001 - Part 1: Standardize the condition for opening popup from window.open. r?smaug!
Attachment #9247574 - Attachment description: WIP: Bug 1701001 - Part 2: Add "is popup" field to browsing context. → WIP: Bug 1701001 - Part 2: Add "is popup" field to browsing context. r?smaug!
Attachment #9247575 - Attachment description: WIP: Bug 1701001 - Part 3: Standardize the BarProp values. → WIP: Bug 1701001 - Part 3: Standardize the BarProp values. r?smaug!
Attachment #9247573 - Attachment description: WIP: Bug 1701001 - Part 1: Standardize the condition for opening popup from window.open. r?smaug! → Bug 1701001 - Part 1: Standardize the condition for opening popup from window.open. r?smaug!
Attachment #9247574 - Attachment description: WIP: Bug 1701001 - Part 2: Add "is popup" field to browsing context. r?smaug! → Bug 1701001 - Part 2: Add "is popup" field to browsing context. r?smaug!
Attachment #9247575 - Attachment description: WIP: Bug 1701001 - Part 3: Standardize the BarProp values. r?smaug! → Bug 1701001 - Part 3: Standardize the BarProp values. r?smaug!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/0e2ca3cc650e Part 1: Standardize the condition for opening popup from window.open. r=smaug https://hg.mozilla.org/integration/autoland/rev/b0e47b1f4d39 Part 2: Add "is popup" field to browsing context. r=smaug https://hg.mozilla.org/integration/autoland/rev/ff439d9c0391 Part 3: Standardize the BarProp values. r=smaug

Backed out 4 changesets (Bug 1737832, Bug 1701001) for causing geckoview failures on noopener-noreferrer-BarProp.window.html.
Backout link
Push with failures
Failure Log

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/f1acae799749 Part 1: Standardize the condition for opening popup from window.open. r=smaug https://hg.mozilla.org/integration/autoland/rev/eea9fe1bf6ea Part 2: Add "is popup" field to browsing context. r=smaug https://hg.mozilla.org/integration/autoland/rev/0de6f75576d0 Part 3: Standardize the BarProp values. r=smaug
Regressions: 1739753
Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: