1701283 - AutofillManager.commit throws SecurityException

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Crash report: https://crash-stats.mozilla.org/report/index/a9fdf4f5-9073-4dcc-aeb8-f164f0210326

Java stack trace:

java.lang.SecurityException: get application info: Neither user 1010243 nor current process has android.permission.INTERACT_ACROSS_USERS.
	at android.os.Parcel.createException(Parcel.java:1953)
	at android.os.Parcel.readException(Parcel.java:1921)
	at android.os.Parcel.readException(Parcel.java:1871)
	at android.view.autofill.IAutoFillManager$Stub$Proxy.finishSession(IAutoFillManager.java:689)
	at android.view.autofill.AutofillManager.finishSessionLocked(AutofillManager.java:1542)
	at android.view.autofill.AutofillManager.commitLocked(AutofillManager.java:1186)
	at android.view.autofill.AutofillManager.commit(AutofillManager.java:1177)
	at org.mozilla.geckoview.GeckoView$AndroidAutofillDelegate.onAutofill(GeckoView.java:14)
	at org.mozilla.geckoview.Autofill$Support.maybeDispatch(Autofill.java:2)
	at org.mozilla.geckoview.Autofill$Support.commit(Autofill.java:4)
	at org.mozilla.geckoview.Autofill$Support.handleMessage(Autofill.java:8)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:1)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:201)
	at android.app.ActivityThread.main(ActivityThread.java:6810)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)
Caused by: android.os.RemoteException: Remote stack trace:
	at android.app.ContextImpl.enforce(ContextImpl.java:1822)
	at android.app.ContextImpl.enforceCallingOrSelfPermission(ContextImpl.java:1850)
	at com.android.server.pm.permission.PermissionManagerService.enforceCrossUserPermission(PermissionManagerService.java:2007)
	at com.android.server.pm.permission.PermissionManagerService.access$2000(PermissionManagerService.java:89)
	at com.android.server.pm.permission.PermissionManagerService$PermissionManagerInternalImpl.enforceCrossUserPermission(PermissionManagerService.java:2192)

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Note: Not all of the linked crashes are of the signature in the comment above.

Comment 2

[[:owlish] 🦉 PST]

Attachment: WIP: Bug 1701283 - Catch security exceptions thrown by Android Autofill Manager

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c82840a55458
WIP: Bug 1701283 - Catch security exceptions thrown by Android Autofill Manager r=geckoview-reviewers,aklotz

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c82840a55458