1786862 - Crash in [@ java.lang.SecurityException: at android.os.Parcel.createException(Parcel.java)]

Status: RESOLVED FIXED

(GeckoView :: Core, defect, P2)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

Bug 1701283 is back again.

Crash report: https://crash-stats.mozilla.org/report/index/682404a1-4322-47ba-bcf7-149000220824

Java stack trace:

java.lang.SecurityException
	at android.os.Parcel.createException(Parcel.java:1953)
	at android.os.Parcel.readException(Parcel.java:1921)
	at android.os.Parcel.readException(Parcel.java:1871)
	at android.view.autofill.IAutoFillManager$Stub$Proxy.finishSession(IAutoFillManager.java:689)
	at android.view.autofill.AutofillManager.finishSessionLocked(AutofillManager.java:1549)
	at android.view.autofill.AutofillManager.commitLocked(AutofillManager.java:1193)
	at android.view.autofill.AutofillManager.commit(AutofillManager.java:1184)
	at org.mozilla.geckoview.GeckoView$AndroidAutofillDelegate.onSessionCommit(GeckoView.java:3)
	at org.mozilla.geckoview.Autofill$Support.commit(Autofill.java:6)
	at org.mozilla.geckoview.Autofill$Support.handleMessage(Autofill.java:20)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:2)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:207)
	at android.app.ActivityThread.main(ActivityThread.java:6878)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:876)

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

I guess that this is regression by bug 1755094 since this re-writes autofill.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1755094

Comment 3

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Bug 1786862 - Add try-catch block for SecurityException by autofill manager. r=#geckoview-reviewers

Original issue was bug 1701283, but that fix was removed by bug 1755094
unfortunately.

Some devices (autofill service?) seem to throw a SecurityException when
calling autofill manager. So we need try-catch block for it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1761651abdf
Add try-catch block for SecurityException by autofill manager. r=geckoview-reviewers,calu

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f1761651abdf