1701346 - Revert QM_OR_ELSE_WARN to ordinary orElse in places where NS_ERROR_FILE_ALREADY_EXISTS/NS_ERROR_FILE_NOT_FOUND/NS_ERROR_FILE_TARGET_DOES_NOT_EXIST needs to be just ignored

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P1)

Description

[Jan Varga [:janv]]

See https://phabricator.services.mozilla.com/D108424#inline-614005

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in EnsureDirectory; r=asuth,#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1701346 - IDB: Revert QM_OR_ELSE_WARN to ordinary orElse in QuotaClient::GetUsageForOriginInternal; r=asuth,#dom-storage

Depends on D109987

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1701346 - LSNG: Revert QM_OR_ELSE_WARN to ordinary orElse in ExistsAsFile; r=asuth,#dom-storage

Depends on D109991

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14e56036de5c
QM: Revert QM_OR_ELSE_WARN to ordinary orElse in EnsureDirectory; r=jstutte

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/14e56036de5c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/863ab090e28a
IDB: Revert QM_OR_ELSE_WARN to ordinary orElse in QuotaClient::GetUsageForOriginInternal; r=asuth,dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/6c1a2d9d4334
LSNG: Revert QM_OR_ELSE_WARN to ordinary orElse in ExistsAsFile; r=asuth,dom-storage-reviewers,jstutte

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/863ab090e28a
https://hg.mozilla.org/mozilla-central/rev/6c1a2d9d4334

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1701346 - QM: Fix the comment in EnsureDirectory; r=asuth,#dom-storage

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1701346 - QM: Add a comment for QM_OR_ELSE_WARN in CreateOrUpgradeDirectoryMetadataHelper::MaybeUpgradeOriginDirectory; r=asuth,#dom-storage

Depends on D113066

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1701346 - CACHE: Revert QM_OR_ELSE_WARN to ordinary orElse in BodyGetCacheDir; r=asuth,#dom-storage

Depends on D113067

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1701346 - CACHE: Revert QM_OR_ELSE_WARN to ordinary orElse in BodyCreateDir; r=asuth,#dom-storage

Depends on D113068

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d9c5f03b8b0
QM: Fix the comment in EnsureDirectory; r=asuth,dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/238e28e08f35
QM: Add a comment for QM_OR_ELSE_WARN in CreateOrUpgradeDirectoryMetadataHelper::MaybeUpgradeOriginDirectory; r=asuth,dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/6c58b606570e
CACHE: Revert QM_OR_ELSE_WARN to ordinary orElse in BodyGetCacheDir; r=asuth,dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/e32570129605
CACHE: Revert QM_OR_ELSE_WARN to ordinary orElse in BodyCreateDir; r=asuth,dom-storage-reviewers,jstutte

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0d9c5f03b8b0
https://hg.mozilla.org/mozilla-central/rev/238e28e08f35
https://hg.mozilla.org/mozilla-central/rev/6c58b606570e
https://hg.mozilla.org/mozilla-central/rev/e32570129605

Comment 14

[Jan Varga [:janv]]

Attachment: Bug 1701346 - CACHE: Add explanatory comments for some ordinary orElse uses; r=#dom-storage

Comment 15

[Jan Varga [:janv]]

Attachment: Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in GetDirEntryKind; r=#dom-storage

Depends on D113526

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecbf5c7d3a62
CACHE: Add explanatory comments for some ordinary orElse uses; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/1ea87880589f
QM: Revert QM_OR_ELSE_WARN to ordinary orElse in GetDirEntryKind; r=dom-storage-reviewers,asuth

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ecbf5c7d3a62
https://hg.mozilla.org/mozilla-central/rev/1ea87880589f

Comment 18

[Jan Varga [:janv]]

Attachment: Bug 1701346 - Add QM_OR_ELSE_LOG and QM_OR_ELSE_LOG_IF macros; r=#dom-storage

Comment 19

[Jan Varga [:janv]]

Attachment: Bug 1701346 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=#dom-storage

This is more consistent with other cases where we either use QM_OR_ELSE_WARN or
QM_OR_ELSE_NOTE. We will later change some uses of QM_OR_ELSE_LOG to
QM_OR_ELSE_LOG_IF. The switch from custom OrElseIf to Result::orElseIf will be
easier when we don't use OrElseIf directly.

Depends on D114936

Comment 20

[Phabricator Automation]

Comment on attachment 9221726 [details]
Bug 1701346 - Add QM_OR_ELSE_LOG and QM_OR_ELSE_LOG_IF macros; r=#dom-storage

Revision D114936 was moved to bug 1711181. Setting attachment 9221726 [details] to obsolete.

Comment 21

[Phabricator Automation]

Comment on attachment 9221758 [details]
Bug 1701346 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=#dom-storage

Revision D115055 was moved to bug 1711181. Setting attachment 9221758 [details] to obsolete.

Comment 22

[Jan Varga [:janv]]

There are still some QM_OR_ELSE_WARN that can spam the reports. However, there's now a new approach for it in bug 1711181, so this bug has been closed.