1711181 - Introduce QM_OR_ELSE_LOG and use it in places where QM_OR_ELSE_WARN would spam the reports

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This is a follow-up for bug 1701346. Originally, we converted QM_OR_ELSE_WARN back to ordinary orElse, but we now see that it's better to use macros in all cases. We just need a new macro that doesn't report to console/browser console/telemetry.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1711181 - Add QM_OR_ELSE_LOG macro; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1711181 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=#dom-storage

This is more consistent with other cases where we either use QM_OR_ELSE_WARN or
QM_OR_ELSE_NOTE. We will later change some uses of QM_OR_ELSE_LOG to
QM_OR_ELSE_LOG_IF. The switch from custom OrElseIf to Result::orElseIf will be
easier when we don't use OrElseIf directly.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1711181 - Use QM_OR_ELSE_LOG in remaining places where QM_OR_ELSE_WARN would spam the reports; r=#dom-storage

Depends on D115055

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1711181 - Add explanatory comments for some special uses of QM_OR_ELSE_WARN; r=#dom-storage

Depends on D115159

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f0fff2a8865
Add QM_OR_ELSE_LOG macro; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/0c5cdbcd703a
Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/f85776cea45d
Use QM_OR_ELSE_LOG in remaining places where QM_OR_ELSE_WARN would spam the reports; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/03de354b3a73
Add explanatory comments for some special uses of QM_OR_ELSE_WARN; r=dom-storage-reviewers,jstutte

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f0fff2a8865
https://hg.mozilla.org/mozilla-central/rev/0c5cdbcd703a
https://hg.mozilla.org/mozilla-central/rev/f85776cea45d
https://hg.mozilla.org/mozilla-central/rev/03de354b3a73