1701353 - moz-phab incorrectly displays 'It will be submitted as "Changes Planned"'

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Botond Ballo [:botond]]

I tried submitting a patch with no reviewer specified, and moz-phab told me:

$ moz-phab submit -s
Submitting 1 commit as Work In Progress
(New) 644202:cc95b3464112 Bug 1699868 - Add a test exercising hit-testing on an overscrolled subframe
!! Missing reviewers
   It will be submitted as "Changes Planned".
   Run submit again with --no-wip to prevent this.
cc95b3464112 is based off non-public commit 2f94ff2763b9
Submit to https://phabricator.services.mozilla.com (YES/No/Always)? no

So I tried again with --no-wip, but got the same warning:

$ moz-phab submit -s --no-wip
Submitting 1 commit for review
(New) 644202:cc95b3464112 Bug 1699868 - Add a test exercising hit-testing on an overscrolled subframe
!! Missing reviewers
   It will be submitted as "Changes Planned".
   Run submit again with --no-wip to prevent this.
cc95b3464112 is based off non-public commit 2f94ff2763b9
Submit to https://phabricator.services.mozilla.com (YES/No/Always)?

I went ahead and submitted, and the --no-wip did have the intended effect (the status was not "Changes Planned"), and it's just the message that's incorrect.

Comment 1

[:glob ✱]

Attachment: Bug 1701353 - moz-phab incorrectly displays 'It will be submitted as "Changes Planned"'; r=zeid

Comment 2

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/497a2724dcc1d8b9b21bac4399df1c7f6283d7ea