1701525 - In AM the Junk Settings and SMTP server richlistitems have some issues

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

In Account Manager in Junk Settings have the AB item's checkboxes no padding to the box and in SMTP have the severs in the list not enough padding.

Also with dark theme are they unreadable when they are selected and the window is inactive.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1701525-AM-richlistitems.patch

I gave a padding of 10px.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9212073 [details] [diff] [review]
1701525-AM-richlistitems.patch

Review of attachment 9212073 [details] [diff] [review]:
-----------------------------------------------------------------

Good work!
Since we're here, would be possible to change this description to be styled like the tip-caption we use in the e2ee encryption section? https://searchfox.org/comm-central/rev/c96bef7839f29e11313cad9d7a3cb15f83034f90/mailnews/base/prefs/content/am-junk.xhtml#124

I know it's a bit out of scope from this bug but it would make much more sense.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1701525-AM-richlistitems.patch

(In reply to Alessandro Castellani [:aleca] from comment #2)

Comment on attachment 9212073 [details] [diff] [review]
1701525-AM-richlistitems.patch

Review of attachment 9212073 [details] [diff] [review]:

Good work!
Since we're here, would be possible to change this description to be styled
like the tip-caption we use in the e2ee encryption section?
https://searchfox.org/comm-central/rev/
c96bef7839f29e11313cad9d7a3cb15f83034f90/mailnews/base/prefs/content/am-junk.
xhtml#124

Done

Comment 4

[Richard Marti (:Paenglab)]

Attachment: screenshot.png

How the tip-caption looks.

Comment 5

[Alessandro Castellani [:aleca]]

Perfect, more in context as that description uniquely applies to the checkbox above.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/711b34e89fe3
Improve the richlistitems in Account Manager. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9212287 [details] [diff] [review]
1701525-AM-richlistitems.patch

[Approval Request Comment]
User impact if declined: UI issues
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9212287 [details] [diff] [review]
1701525-AM-richlistitems.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 88.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2944b999c3c5

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9212287 [details] [diff] [review]
1701525-AM-richlistitems.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.9.1:
https://hg.mozilla.org/releases/comm-esr78/rev/f3f1f4a0e32a