1701544 - "Send Tab to Device" action lost visual feedback (blue tick) with proton enabled

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Albert Scheiner [:alberts]]

Attachment: send-tab-to-device-feedback.png

In current builds when sending a tab to a device there is a visual clue in form of a blue box with a tick icon and the wording "Send!" (see screenshot).
It appears underneath the page action buttons.

This is true for all ways to triggering it I could find, via the page action button, context menu and application menu.

Once proton is switched on only context menu and application menu, neither of which trigger the visual clue.

Comment 1

[Marco Bonardo [:mak]]

I don't think this applies to the address bar anymore, if there should be a visual indicator then it should probably be elsewhere

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1697191

Comment 3

[Blake Winton (:bwinton) (:☕️)]

UX says that we should hang the notification off of the FxA button (since in order to send a tab from one device to another you need an FxA account), and fall back to the AppMenu if the FxA button has been removed from the toolbar.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1701544 - Show Sent! confirmation when sending a tab to a device r?harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d2c85fb7ce
Show Sent! confirmation when sending a tab to a device r=harry,desktop-theme-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/24d2c85fb7ce

Comment 7

[Albert Scheiner [:alberts]]

Looking good! Thanks :)

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

(Answering for Mark)
Yes, it is. (And in general, any of the [proton-*][priority:2a] bugs will be.)
It was the weekend, but I suspect an MR1-uplift request is coming in the near future… 😉

Comment 10

[Mark Striemer [:mstriemer]]

Comment on attachment 9217581 [details]
Bug 1701544 - Show Sent! confirmation when sending a tab to a device r?harry

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Send a tab to another device

2. Verify there's a confirmation on success

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adding back old behaviour, includes new tests.
• String changes made/needed: None

Comment 12

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the messages for sent tabs are visible on Firefox 90.0a1 (2021-04-27). Tests were performed on Windows 10, macOS 10.15.7 and Ubuntu 20.04.

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9217581 [details]
Bug 1701544 - Show Sent! confirmation when sending a tab to a device r?harry

Approved for 89 beta 6, thanks.

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fb75c4e8b45

Comment 15

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the messages for sent tabs are visible on Firefox 89.0b6 (20210429010626 - treeherder build). Tests were performed on Windows 10, macOS 10.15.7 and Ubuntu 20.04.