1701638 - middle-clicking on tab insert text into address bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Maxim]

Attachment: 20210329-183013.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Firefox version: 87.0

1. Copy MULTI-LINE text
2. Open firefox
3. Open a new tab
4. Close the old tab

Actual results:

The tab is closed and the text from the clipboard is pasted into a new tab

Expected results:

Close a tab without pasting text from the clipboard into a new tab

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce on Nightly 89.0a1 Ubuntu20.04.
And I can also reproduce on Windows if middlemouse.paste = true.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=81bec1bb5b4e34a819dc9159b194f1896edd2436&tochange=22e706c2ff1d4469907bc44c8c1bc256512553e7

Comment 3

[Drew Willcoxon :adw]

Daisuke, do you have time to look at this?

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much for reporting, Maxim!
And also, thank you very much for confirming, Alice0775!

Yes, I also could reproduce this issue on the current m-c on Ubuntu 18.04.5 LTS.
(Could not reproduce it on OSX 10.14.6 with/without middlemouse.paste pref)
I will take a look at this.

(Thank you for letting me know, Drew!)

Comment 5

[Daisuke Akatsuka (:daisuke)]

Sorry, I could reproduce it on OSX as well.

Comment 6

[Daisuke Akatsuka (:daisuke)]

I investigated the reason for this issue.
First, even if we get rid of the patch of bug 1185358, we can reproduce a similar issue.

STR:

1. Copy the following multiline test.

java
script:alert(1);

2. Paste with middle click

Then a tab will be removed and alert(1); is pasted to the URLBar by https://hg.mozilla.org/mozilla-central/rev/e4a60e1d9ef527ebc960f7ebc589b24e9d7681b1#l1.12 .

It seems that a fundamental fix is needed, such as when the tab is removed by middle-clicking, avoid pasting the value.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1701638: Call preventDefault for middle click event on a tab to avoid pasting by the event.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f22e93f12cc6
Call preventDefault for middle click event on a tab to avoid pasting by the event. r=masayuki,adw

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f22e93f12cc6

Comment 10

[Florencia Di Ciocco, NI to vbalducci]

I've verified that if I middle-click to the right of the plus sign, the one that opens a new tab, a mew tab is opened with the text copied on the address bar. As mentioned above, I have middlemouse.paste = true. Is this the expected result?

Comment 11

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the verifying and the reporting, Florencia!
Yeah, that is an unexpected result. Now, we are fixing the issue in bug 1710289.
Thanks.

Comment 12

[Florencia Di Ciocco, NI to vbalducci]

Hi,
Thanks for the answer. Then I've verified that this has been fixed on Beta 89.0b10.

Regards, Flor.