1185358 - Paste words in location bar: newlines are removed, words are merged

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Delplace]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150629114848

Steps to reproduce:

Pasted this multi-line string into the awesome location bar:
White House
Washington DC
USA


Actual results:

My string got transformed and this is what got in the bar:
White HouseWashington DCUSA


Expected results:

White House Washington DC USA

Comment 1

[Delplace]

2 legit use cases are conflicting here.

First, when user wants to paste an URL, and this URL might have been broken into piece by a mail software or other. The correct behavior is to remove the newline and merge the long URL pieces, as discussed in bug 1014246. This already works.

Second, when user wants to search terms (e.g. a geographic address, a sentence, etc.). The correct behavior is to replace each newline by a space. This currently doesn't work.

I understand the choice might not always be obvious. Afaict, the same use cases in Chromium always work as expected.

Comment 2

[Marco Bonardo [:mak]]

we should be able to detect if the string looks like a url or not, in most cases.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1185358: Replace any whitespace chars with space.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1185358: Update untrimmedValue even if pasted value is changed.

Depends on D105726

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a60e1d9ef5
Replace any whitespace chars with space. r=adw
https://hg.mozilla.org/integration/autoland/rev/22e706c2ff1d
Update untrimmedValue even if pasted value is changed. r=adw

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e4a60e1d9ef5
https://hg.mozilla.org/mozilla-central/rev/22e706c2ff1d

Comment 9

[Petruta Horea [:phorea], Desktop QA]

The issue as described in comment 0, and other similar test cases, is no longer reproducible in latest 87 beta 5 across OS's, so I'm marking this as verified.

However, the two duplicates bug 1327589 (STR_1) and bug 1606260 are still valid, so it would probably be best to re-open them (or mark as Wontfix).

Daisuke-san, what would be the best approach in this case? Thank you!

Comment 10

[Daisuke Akatsuka (:daisuke)]

Hi Petruta-san, thank you very much for letting me know about them!
I took a look at them, it seems that the bugs are not fixed yet, as you said.
I will re-open them.
Thanks!