1701645 - Fix more tests that fail with proton enabled

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

See bug 1701202.

Trypush after that still had a bunch of failing tests: https://treeherder.mozilla.org/jobs?repo=try&revision=0cb2a0177495d59e4bcdf1bf49e02fc444233701 .

We've also graduated tabs now and it would not surprise me if that yielded more failing tests.

This should also probably be P1 given it blocks enabling proton by default.

Comment 1

[:Gijs (he/him)]

I have local fixes for the UITour stuff. Now looking at browser/components/customizableui/test/browser_914138_widget_API_overflowable_toolbar.js and other CUI tests . It also looks like browser/components/extensions/test/browser/browser_ext_popup_corners.js is still unhappy on Windows 7, and layout/base/tests/chrome/test_printpreview.xhtml | Printing printpreview_pps_uw9.html and printpreview_pps_uw9_ref.html should produce the same results is also still failing. Those appear to be the main things.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1701645 - part 1: re-fix UITour tests and CUI test

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1701645 - adjust Windows max different in test_printpreview.xhtml to pass with proton, r?dholbert

Proton changes the vertical size of the browser chrome which changes the size of the content area,
which in turn affects the fuzz/difference factor required for this test on Windows.

Depends on D110111

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1701645 - actually use 8px border radius for panels on Windows 7, r?mconley

Depends on D110112

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf3dd441291c
part 1: re-fix UITour tests and CUI test r=mconley
https://hg.mozilla.org/integration/autoland/rev/55914d0004bb
adjust Windows max different in test_printpreview.xhtml to pass with proton, r=dholbert
https://hg.mozilla.org/integration/autoland/rev/15c3815df07b
actually use 8px border radius for panels on Windows 7, r=mconley

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bf3dd441291c
https://hg.mozilla.org/mozilla-central/rev/55914d0004bb
https://hg.mozilla.org/mozilla-central/rev/15c3815df07b