Closed Bug 1701689 Opened 2 months ago Closed 29 days ago

The weight of the link in the “Import Error” modal is smaller than it should be

Categories

(Firefox :: about:logins, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox88 --- wontfix
firefox89 --- verified

People

(Reporter: mheres, Assigned: anshukaira, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 1 obsolete file)

Attached image smaller weight.png

[Affected Versions]:

  • Firefox Beta 88.0b4 (Build ID: 20210328185936)
  • Firefox Nightly 89.0a1 (Build ID: 20210329095128)

[Affected Platforms]:

  • Linux Mint 20
  • Windows 10
  • macOS 10.15.7

[Prerequisites]:

  • Have Firefox open.

[Steps to reproduce]:

  1. Navigate to “about:logins”.
  2. Click the meatball menu button (“...”).
  3. Choose the “Import from a File...” option.
  4. Choose a CSV file without a header and import it.
  5. Observe the text of the “Import Error” modal.

[Expected result]:

  • The font of the “Learn more” link has a larger weight.

[Actual result]:

  • The font of the “Learn more” link seems to have a smaller weight than in the documentation.

[Notes]:

  • Attached is a screenshot of the issue compared to the documentation.
Mentor: tgiles
Keywords: good-first-bug
Priority: -- → P3

Hi
I have already worked on about:logins component for a good-first-bug.
would it be okay for me to work on this??

Flags: needinfo?(tgiles)

Hi Kaira, feel free to go ahead and work on this bug!

To help Mozilla out with this bug, here's the steps:

  1. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the
      Developer Guide,
      which has answers to most development questions.
  2. Start working on this bug.
    • You'll need to change the font weight on the "Learn more" link. This style should live in the import-error-dialog.css file.
    • If "Import From a File" in not available for you, you will need to enable the feature through about:config
      • You will need to enable the signon.management.page.fileImport.enabled preference
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
  3. Build your change with mach build and test your change with mach test browser/components/aboutlogins --headless. Also check your changes for adherence to our style guidelines by using mach lint.
  4. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  5. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
Assignee: nobody → anshusinghjsk
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a26cd17142a
Make error link bold in import CSV error dialog. r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Attachment #9216061 - Attachment is obsolete: true
See Also: → 1706047

I have verified that the font has been changed to be thicker for the "Learn More" link and as such I wll mark this issue as verified fixed.
As the weight seems now to be too large, I have opened Bug 1706047.
Tested using Firefox Nightly 89.0a1 (Build ID: 20210418213620) on Windows 10, Linux Mint 20 and macOS 11.1.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.