1701689 - The weight of the link in the “Import Error” modal is smaller than it should be

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: smaller weight.png

[Affected Versions]:

• Firefox Beta 88.0b4 (Build ID: 20210328185936)
• Firefox Nightly 89.0a1 (Build ID: 20210329095128)

[Affected Platforms]:

• Linux Mint 20
• Windows 10
• macOS 10.15.7

[Prerequisites]:

• Have Firefox open.

[Steps to reproduce]:

1. Navigate to “about:logins”.
2. Click the meatball menu button (“...”).
3. Choose the “Import from a File...” option.
4. Choose a CSV file without a header and import it.
5. Observe the text of the “Import Error” modal.

[Expected result]:

• The font of the “Learn more” link has a larger weight.

[Actual result]:

• The font of the “Learn more” link seems to have a smaller weight than in the documentation.

[Notes]:

• Attached is a screenshot of the issue compared to the documentation.

Comment 1

[kaira [:anshukaira]]

Hi
I have already worked on about:logins component for a good-first-bug.
would it be okay for me to work on this??

Comment 2

[Tim Giles [:tgiles]]

Hi Kaira, feel free to go ahead and work on this bug!

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug.
   • You'll need to change the font weight on the "Learn more" link. This style should live in the import-error-dialog.css file.
   • If "Import From a File" in not available for you, you will need to enable the feature through about:config
     • You will need to enable the signon.management.page.fileImport.enabled preference
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/aboutlogins --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 3

[kaira [:anshukaira]]

Attachment: Bug 1701689 added a class(for increasing font-weight) to learn-more link in error dialogue box for about:logins import csv file option. r=tgiles

Comment 4

[kaira [:anshukaira]]

Attachment: Bug 1701689 - Make error link bold in import CSV error dialog. r=tgiles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a26cd17142a
Make error link bold in import CSV error dialog. r=tgiles

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a26cd17142a

Comment 7

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the font has been changed to be thicker for the "Learn More" link and as such I wll mark this issue as verified fixed.
As the weight seems now to be too large, I have opened Bug 1706047.
Tested using Firefox Nightly 89.0a1 (Build ID: 20210418213620) on Windows 10, Linux Mint 20 and macOS 11.1.