1701740 - Dialog box background is incorrect color

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Joe McCabe]

Attachment: Screen Shot 2021-03-29 at 10.47.11 AM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

OS: macOS Big Sur, 11.3 Beta (20E5217a)
OS set to "Dark Mode"
Thunderbird: 88.0b1
Default theme

Right-click/Ctrl-click on a Saved Search
Select Properties

Actual results:

Observe that dialog box that opens is white background, white text, and SOME dark GUI elements (see screen shot)

Expected results:

Dialog box should present in Dark Mode to match OS settings, OR should present in Light Mode and be usable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1701740-mac-dialog-appearance.patch

This comes through some Mac appearance changes on M-C for dialogs.

This patch fixes the issue for me.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9212577 [details] [diff] [review]
1701740-mac-dialog-appearance.patch

Review of attachment 9212577 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes it, thanks.
Are you able to find the bug that regressed this? Just to have a record.

Nit, please update the commit message to: "[macOS] Set host and root appearance: none for theamable dialogs"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1701740-mac-dialog-appearance.patch

Updated commit message.

Sorry they did so many changes for the non-native theming they have enabled as default that I can't say which one. I think it was mostly in cpp or Objective-C.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b207f928cecd
[Mac] Set host and root appearance: none for theamable dialogs. r=aleca

Comment 5

[Joe McCabe]

Installed 88.0b2. Behavior persists.

Comment 6

[Richard Marti (:Paenglab)]

It's in Daily and not in beta. Don't reopen for such cases.