1701744 - [Linux] Consider using OS accent color in-content rather than hardcoded colors for proton's default theme

Status: NEW

(Firefox :: General, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

At least on the default theme, on GTK, it feels much better to use -moz-accent-color etc than rgb(21,20,26). We use system colors for tab / menu backgrounds etc and in many other places, and the default form controls also use that.

We have a matching foreground system color, and we can darken / lighten them as needed like the non-native-theme does. I believe this would look better on macOS at least, too.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I was told by bwinton that we generally don't want to do this (which I personally feel sad about). But if we take that route, shouldn't we fix the system colors / selection colors we expose to the page to be consistent? Otherwise you get e.g. orange selection in ubuntu, but a blue accent color, which is really odd.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Some very incomplete list of places where right now use the OS accent colors which affect content:

• Form controls (outlines / borders / checkbox backgrounds / <select multiple> checked options)
• Text selection colors.
• Scrollbar active buttons on GTK.

Comment 3

[Harry Twyford]

My understanding is that we're making a special exception for Linux to support system themes. The Proton custom colours shouldn't be visible in the Linux default theme, although they are visible when Light/Dark theme is applied. Are you seeing something else?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yes, I have the default theme and about:preferences et. al show the proton very-light-blue-greenish color from the proton dark theme.

Comment 5

[Harry Twyford]

Ah, I see, the in-content colours are wrong. Is the browser chrome using the colours you expect?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah, the URL bar outline seems to be the right color.

Comment 7

[Harry Twyford]

Thanks. I'll update the bug description to be specifically about in-content colours, since bug 1697150 covers chrome colours.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.