Change GetOwnPropertyDescriptor to return Maybe<PropertyDescriptor>
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Right now we encode "undefined" PropertyDescriptors by setting the JSObject field to null. However that field should not even exists on normal PropertyDescriptor. Instead use Maybe to encode missing/undefined PropertyDescriptors.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D110228
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D110229
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/91c911c34a19 Add a new GetOwnPropertyDescriptor function that returns Maybe<PropertyDescriptor>. r=jandem https://hg.mozilla.org/integration/autoland/rev/ab47df2d318a Add methods directly on PropertyDescriptor. r=jandem https://hg.mozilla.org/integration/autoland/rev/722cb95c303c Start using the new GetOwnPropertyDescriptor overload in Object.cpp. r=jandem
Assignee | ||
Comment 5•3 years ago
|
||
Comment 6•3 years ago
|
||
bugherder |
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e6408add963c Start using the new GetOwnPropertyDescriptor overload in a few more places. r=jandem
Assignee | ||
Comment 8•3 years ago
|
||
Comment 9•3 years ago
|
||
bugherder |
Comment 10•3 years ago
|
||
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f5106f6c193d Use the new GetOwnPropertyDescriptor function in ScriptedProxyHandler. r=jandem
Comment 11•3 years ago
|
||
bugherder |
Assignee | ||
Comment 12•3 years ago
|
||
I am not super happy with having to do Rooted<PropertyDescriptor> desc(cx, *desc_);
in DebuggerObject::getOwnPropertyDescriptor.
However PropertyDescriptor::value() can't be resolved properly, unlike MutableHandle<PropertyDescriptor>::value().
I wonder if Maybe could return Handle/MutableHandle as well somehow.
Comment 13•3 years ago
|
||
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b08a8155783d Use Maybe<PropertyDescriptor> in DebuggerObject and a few resulting places. r=jandem
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 14•3 years ago
|
||
I started working on changing the BaseProxyHandler::getOwnPropertyDescriptor. This is going to be a pretty major change, especially in DOM code as well. Let's do it in a new bug.
Comment 15•3 years ago
|
||
bugherder |
Description
•