1701904 - Change GetOwnPropertyDescriptor to return Maybe<PropertyDescriptor>

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tom S. (please needinfo tschuster)]

Right now we encode "undefined" PropertyDescriptors by setting the JSObject field to null. However that field should not even exists on normal PropertyDescriptor. Instead use Maybe to encode missing/undefined PropertyDescriptors.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Add a new GetOwnPropertyDescriptor function that returns Maybe<PropertyDescriptor>. r?jandem

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Add methods directly on PropertyDescriptor. r?jandem

Depends on D110228

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Start using the new GetOwnPropertyDescriptor overload in Object.cpp. r?jandem

Depends on D110229

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c911c34a19
Add a new GetOwnPropertyDescriptor function that returns Maybe<PropertyDescriptor>. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ab47df2d318a
Add methods directly on PropertyDescriptor. r=jandem
https://hg.mozilla.org/integration/autoland/rev/722cb95c303c
Start using the new GetOwnPropertyDescriptor overload in Object.cpp. r=jandem

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Start using the new GetOwnPropertyDescriptor overload in a few more places. r?jandem

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/91c911c34a19
https://hg.mozilla.org/mozilla-central/rev/ab47df2d318a
https://hg.mozilla.org/mozilla-central/rev/722cb95c303c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6408add963c
Start using the new GetOwnPropertyDescriptor overload in a few more places. r=jandem

Comment 8

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Use the new GetOwnPropertyDescriptor function in ScriptedProxyHandler. r?jandem

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e6408add963c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5106f6c193d
Use the new GetOwnPropertyDescriptor function in ScriptedProxyHandler. r=jandem

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f5106f6c193d

Comment 12

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1701904 - Use Maybe<PropertyDescriptor> in DebuggerObject and a few resulting places. r?jandem

I am not super happy with having to do Rooted<PropertyDescriptor> desc(cx, *desc_); in DebuggerObject::getOwnPropertyDescriptor.
However PropertyDescriptor::value() can't be resolved properly, unlike MutableHandle<PropertyDescriptor>::value().

I wonder if Maybe could return Handle/MutableHandle as well somehow.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b08a8155783d
Use Maybe<PropertyDescriptor> in DebuggerObject and a few resulting places. r=jandem

Comment 14

[Tom S. (please needinfo tschuster)]

I started working on changing the BaseProxyHandler::getOwnPropertyDescriptor. This is going to be a pretty major change, especially in DOM code as well. Let's do it in a new bug.

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b08a8155783d