1700958 - Clean up PropertyDescriptor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

Bug 1470081 is cleaning up the getter/setter code in PropertyDescriptor, but there's more to do:

• setGetter and setSetter probably shouldn't exist at all.
• For the attributes it would also be nicer to have checked accessors instead of just exposing the underlying field directly.
• There's an object field that's set for lookups, but this doesn't really belong in the property descriptor. It would be nicer to have a separate type that contains this object + a PropertyDescriptor.

Comment 1

[Tom S. (please needinfo tschuster)]

Great! Sadly we use object() in a lot of places to check if the PropertyDescriptor is not undefined (in spec terms). Making this more explicit would be great. I might give that part a shot during the weekend.

Comment 2

[Tom S. (please needinfo tschuster)]

I can't really think of any additional improvements. We are in a pretty good state now.